From: <Codrin.Ciubotariu@microchip.com>
To: <jakobkoschel@gmail.com>
Cc: <arnd@arndb.de>, <gregkh@linuxfoundation.org>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Claudiu.Beznea@microchip.com>, <cezary.rojewski@intel.com>,
<pierre-louis.bossart@linux.intel.com>,
<liam.r.girdwood@linux.intel.com>, <yang.jie@linux.intel.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<orsonzhai@gmail.com>, <baolin.wang7@gmail.com>,
<zhang.lyra@gmail.com>, <yangyingliang@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<rppt@kernel.org>, <bjohannesmeyer@gmail.com>,
<c.giuffrida@vu.nl>, <h.j.bos@vu.nl>
Subject: Re: [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable
Date: Tue, 5 Apr 2022 06:44:31 +0000 [thread overview]
Message-ID: <a82fb96b-6c34-25ed-47bc-53a755366676@microchip.com> (raw)
In-Reply-To: <20220331215003.882143-3-jakobkoschel@gmail.com>
On 01.04.2022 00:50, Jakob Koschel wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
>
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
>
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
>
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1]
> Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
next prev parent reply other threads:[~2022-04-05 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 21:50 [PATCH 1/3] ASoC: Intel: catpt: remove check of list iterator against head past the loop body Jakob Koschel
2022-03-31 21:50 ` [PATCH 2/3] ASoC: sprd: " Jakob Koschel
2022-04-01 2:12 ` Baolin Wang
2022-03-31 21:50 ` [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable Jakob Koschel
2022-04-05 6:44 ` Codrin.Ciubotariu [this message]
2022-04-01 7:00 ` [PATCH 1/3] ASoC: Intel: catpt: remove check of list iterator against head past the loop body Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a82fb96b-6c34-25ed-47bc-53a755366676@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Claudiu.Beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=bjohannesmeyer@gmail.com \
--cc=broonie@kernel.org \
--cc=c.giuffrida@vu.nl \
--cc=cezary.rojewski@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=h.j.bos@vu.nl \
--cc=jakobkoschel@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rppt@kernel.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yangyingliang@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®