* [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set
@ 2022-04-01 11:50 Xiaomeng Tong
2022-04-06 7:39 ` Patrik Jakobsson
0 siblings, 1 reply; 2+ messages in thread
From: Xiaomeng Tong @ 2022-04-01 11:50 UTC (permalink / raw)
To: patrik.r.jakobsson
Cc: airlied, daniel, airlied, alan, dri-devel, linux-kernel, Xiaomeng Tong
Instead of exiting the loop as expected when an entry is found, the
list_for_each_entry() continues until the traversal is complete.
when found the entry, add a break after the switch statement.
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
---
drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
index dc467996cce4..9a5ea06a1a8e 100644
--- a/drivers/gpu/drm/gma500/psb_intel_display.c
+++ b/drivers/gpu/drm/gma500/psb_intel_display.c
@@ -135,6 +135,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
is_tv = true;
break;
}
+
+ break;
}
drm_connector_list_iter_end(&conn_iter);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set
2022-04-01 11:50 [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set Xiaomeng Tong
@ 2022-04-06 7:39 ` Patrik Jakobsson
0 siblings, 0 replies; 2+ messages in thread
From: Patrik Jakobsson @ 2022-04-06 7:39 UTC (permalink / raw)
To: Xiaomeng Tong
Cc: David Airlie, Daniel Vetter, Dave Airlie, Alan Cox, dri-devel,
linux-kernel
On Fri, Apr 1, 2022 at 1:50 PM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> Instead of exiting the loop as expected when an entry is found, the
> list_for_each_entry() continues until the traversal is complete.
> when found the entry, add a break after the switch statement.
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Thanks for the patch
Applied to drm-misc-next
> ---
> drivers/gpu/drm/gma500/psb_intel_display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/gma500/psb_intel_display.c b/drivers/gpu/drm/gma500/psb_intel_display.c
> index dc467996cce4..9a5ea06a1a8e 100644
> --- a/drivers/gpu/drm/gma500/psb_intel_display.c
> +++ b/drivers/gpu/drm/gma500/psb_intel_display.c
> @@ -135,6 +135,8 @@ static int psb_intel_crtc_mode_set(struct drm_crtc *crtc,
> is_tv = true;
> break;
> }
> +
> + break;
> }
> drm_connector_list_iter_end(&conn_iter);
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-06 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-01 11:50 [PATCH] drm/gma500: fix a missing break in psb_intel_crtc_mode_set Xiaomeng Tong
2022-04-06 7:39 ` Patrik Jakobsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®