From: Nishanth Menon <nm@ti.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
<linux-kernel@vger.kernel.org>, <cocci@inria.fr>,
Kirill Smelkov <kirr@nexedi.com>
Subject: Re: [PATCH] coccinelle: api/stream_open: Introduce metavariables for checks
Date: Tue, 5 Apr 2022 07:34:17 -0500 [thread overview]
Message-ID: <20220405123417.n6mdou64qidgsfo5@doing> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2204050816560.2185@hadrien>
On 08:17-20220405, Julia Lawall wrote:
>
>
> On Mon, 4 Apr 2022, Nishanth Menon wrote:
>
> > Coccinelle spatch version 1.1.1 reports the following:
> > warning: line 134: should no_llseek be a metavariable?
> > warning: line 141: should noop_llseek be a metavariable?
> > warning: line 223: should nonseekable_open be a metavariable?
> > warning: line 290: should nonseekable_open be a metavariable?
> > warning: line 338: should nonseekable_open be a metavariable?
> >
> > So, introduce the metavariable similar to other check instances.
>
> This changes the semantic from matching the specific thing to anything.
> So are you sure that it is what is wanted? If it should always be the
> specific thing, then you can get rid of the warning using eg symbol
> no_llseek.
Aaah thank you. Will post a v2 with s/identifier/symbol. I still need to
grok the nuance between the two in [1]. Thanks for clarifying.
[...]
[1] https://coccinelle.gitlabpages.inria.fr/website/docs/main_grammar.html
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2022-04-05 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 21:59 Nishanth Menon
2022-04-05 6:17 ` Julia Lawall
2022-04-05 12:34 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405123417.n6mdou64qidgsfo5@doing \
--to=nm@ti.com \
--cc=cocci@inria.fr \
--cc=julia.lawall@inria.fr \
--cc=kirr@nexedi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®