* [PATCH v2] drm/gma500: depend on framebuffer
@ 2022-04-09 3:44 James Hilliard
2022-04-09 4:12 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: James Hilliard @ 2022-04-09 3:44 UTC (permalink / raw)
To: dri-devel
Cc: Randy Dunlap, James Hilliard, Patrik Jakobsson, David Airlie,
Daniel Vetter, linux-kernel
This appears to be needed for video output to function correctly.
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
Changes v1 -> v2:
- use depends instead of select
---
drivers/gpu/drm/gma500/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
index 0cff20265f97..8ea87bfa95f5 100644
--- a/drivers/gpu/drm/gma500/Kconfig
+++ b/drivers/gpu/drm/gma500/Kconfig
@@ -2,6 +2,8 @@
config DRM_GMA500
tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
depends on DRM && PCI && X86 && MMU
+ depends on FB
+ depends on FB_EFI || !EFI
select DRM_KMS_HELPER
# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
select ACPI_VIDEO if ACPI
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/gma500: depend on framebuffer
2022-04-09 3:44 [PATCH v2] drm/gma500: depend on framebuffer James Hilliard
@ 2022-04-09 4:12 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2022-04-09 4:12 UTC (permalink / raw)
To: James Hilliard, dri-devel
Cc: Patrik Jakobsson, David Airlie, Daniel Vetter, linux-kernel
On 4/8/22 20:44, James Hilliard wrote:
> This appears to be needed for video output to function correctly.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
> - use depends instead of select
Thanks.
> ---
> drivers/gpu/drm/gma500/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 0cff20265f97..8ea87bfa95f5 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -2,6 +2,8 @@
> config DRM_GMA500
> tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
> depends on DRM && PCI && X86 && MMU
> + depends on FB
> + depends on FB_EFI || !EFI
I'm OK with the second line of the first patch:
+ select FB_EFI if EFI
It's just that a single driver shouldn't enable an entire subsystem (like FB)
on its own. But once FB is set (depends on in this patch), selecting
FB_EFI would be OK IMO.
> select DRM_KMS_HELPER
> # GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
> select ACPI_VIDEO if ACPI
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-09 4:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-09 3:44 [PATCH v2] drm/gma500: depend on framebuffer James Hilliard
2022-04-09 4:12 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®