* [PATCH] rapidio: Remove redundant variable tmp
@ 2022-04-18 14:58 Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2022-04-18 14:58 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine, linux-kernel; +Cc: kernel-janitors, llvm
Variable tmp is being assigned a value that is never read, the variable
is redundant and can be removed.
Cleans up clang scan build warning:
drivers/rapidio/rio-scan.c:561:10: warning: Although the value stored
to 'tmp' is used in the enclosing expression, the value is never actually
read from 'tmp' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/rapidio/rio-scan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 19b0c33f4a62..5256e76ab29c 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;
if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,8 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
- < port->host_deviceid) {
+ while (rio_get_host_deviceid_lock(port, hopcount) < port->host_deviceid) {
/* Delay a bit */
mdelay(1);
/* Attempt to acquire device lock again */
--
2.35.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] rapidio: remove redundant variable tmp
@ 2024-01-16 11:02 Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2024-01-16 11:02 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine; +Cc: kernel-janitors, linux-kernel
The variable tmp is redundant, it is not being read after the
assignment and hence it can be removed.
Cleans up clang scan build warning:
warning: Although the value stored to 'tmp' is used in the
enclosing expression, the value is never actually read
from 'tmp' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/rapidio/rio-scan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index fdcf742b2adb..8f1bc69f7153 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -528,7 +528,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;
if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -562,8 +561,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
- < port->host_deviceid) {
+ while (rio_get_host_deviceid_lock(port, hopcount) < port->host_deviceid) {
/* Delay a bit */
mdelay(1);
/* Attempt to acquire device lock again */
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] rapidio: Remove redundant variable tmp
@ 2021-12-11 17:52 Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2021-12-11 17:52 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine; +Cc: kernel-janitors, linux-kernel
The variable tmp is being assigned a value but it is never read
afterwards. The assignment is redundant and so is the variable, so
remove tmp.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/rapidio/rio-scan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/rapidio/rio-scan.c b/drivers/rapidio/rio-scan.c
index 19b0c33f4a62..2bc4d1eaf1ce 100644
--- a/drivers/rapidio/rio-scan.c
+++ b/drivers/rapidio/rio-scan.c
@@ -524,7 +524,6 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
{
struct rio_dev *rdev;
u32 regval;
- int tmp;
if (rio_mport_chk_dev_access(port,
RIO_ANY_DESTID(port->sys_size), hopcount)) {
@@ -558,7 +557,7 @@ static int rio_enum_peer(struct rio_net *net, struct rio_mport *port,
rio_mport_write_config_32(port, RIO_ANY_DESTID(port->sys_size),
hopcount,
RIO_HOST_DID_LOCK_CSR, port->host_deviceid);
- while ((tmp = rio_get_host_deviceid_lock(port, hopcount))
+ while (rio_get_host_deviceid_lock(port, hopcount)
< port->host_deviceid) {
/* Delay a bit */
mdelay(1);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-16 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 14:58 [PATCH] rapidio: Remove redundant variable tmp Colin Ian King
-- strict thread matches above, loose matches on Subject: below --
2024-01-16 11:02 [PATCH] rapidio: remove " Colin Ian King
2021-12-11 17:52 [PATCH] rapidio: Remove " Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®