* [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static
@ 2022-04-21 14:43 Tom Rix
2022-05-02 22:24 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-04-21 14:43 UTC (permalink / raw)
To: hjc, heiko, airlied, daniel
Cc: dri-devel, linux-arm-kernel, linux-rockchip, linux-kernel, Tom Rix
Smatch reports this issue
cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?
rk3399_cdn_dp is only used in cdn-dp-core.c so change
its storge-class specifier to static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/rockchip/cdn-dp-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
index d3e6c93739bf..ce67c9daa2b1 100644
--- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
+++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
@@ -48,7 +48,7 @@ struct cdn_dp_data {
u8 max_phy;
};
-struct cdn_dp_data rk3399_cdn_dp = {
+static struct cdn_dp_data rk3399_cdn_dp = {
.max_phy = 2,
};
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static
2022-04-21 14:43 [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static Tom Rix
@ 2022-05-02 22:24 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2022-05-02 22:24 UTC (permalink / raw)
To: Tom Rix, hjc, daniel, airlied
Cc: Heiko Stuebner, linux-arm-kernel, dri-devel, linux-rockchip,
linux-kernel
On Thu, 21 Apr 2022 10:43:04 -0400, Tom Rix wrote:
> Smatch reports this issue
> cdn-dp-core.c:51:20: warning: symbol 'rk3399_cdn_dp' was not declared. Should it be static?
>
> rk3399_cdn_dp is only used in cdn-dp-core.c so change
> its storge-class specifier to static.
Applied, thanks!
[1/1] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static
commit: 7494b1ed1df414e43dc8429f0c016b2054b1b5da
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-02 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 14:43 [PATCH] drm/rockchip: cdn-dp: change rk3399_cdn_dp from global to static Tom Rix
2022-05-02 22:24 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®