* [PATCH] can: ctucanfd: Remove unnecessary print function dev_err()
@ 2022-04-21 20:32 Jiapeng Chong
2022-04-21 21:16 ` Pavel Pisa
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-04-21 20:32 UTC (permalink / raw)
To: pisa
Cc: ondrej.ille, wg, mkl, davem, kuba, pabeni, linux-can, netdev,
linux-kernel, Jiapeng Chong, Abaci Robot
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warnings:
./drivers/net/can/ctucanfd/ctucanfd_platform.c:67:2-9: line 67 is
redundant because platform_get_irq() already prints an error.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/can/ctucanfd/ctucanfd_platform.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c
index 5e4806068662..89d54c2151e1 100644
--- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
+++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
@@ -64,7 +64,6 @@ static int ctucan_platform_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "Cannot find interrupt.\n");
ret = irq;
goto err;
}
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] can: ctucanfd: Remove unnecessary print function dev_err()
2022-04-21 20:32 [PATCH] can: ctucanfd: Remove unnecessary print function dev_err() Jiapeng Chong
@ 2022-04-21 21:16 ` Pavel Pisa
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Pisa @ 2022-04-21 21:16 UTC (permalink / raw)
To: Jiapeng Chong
Cc: ondrej.ille, wg, mkl, davem, kuba, pabeni, linux-can, netdev,
linux-kernel, Abaci Robot
Thanks for checking
On Thursday 21 of April 2022 22:32:42 Jiapeng Chong wrote:
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Eliminate the follow coccicheck warnings:
>
> ./drivers/net/can/ctucanfd/ctucanfd_platform.c:67:2-9: line 67 is
> redundant because platform_get_irq() already prints an error.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Pave Pisa <pisa@cmp.felk.cvut.cz>
> drivers/net/can/ctucanfd/ctucanfd_platform.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c
> b/drivers/net/can/ctucanfd/ctucanfd_platform.c index
> 5e4806068662..89d54c2151e1 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
> @@ -64,7 +64,6 @@ static int ctucan_platform_probe(struct platform_device
> *pdev) }
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(dev, "Cannot find interrupt.\n");
> ret = irq;
> goto err;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 21:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 20:32 [PATCH] can: ctucanfd: Remove unnecessary print function dev_err() Jiapeng Chong
2022-04-21 21:16 ` Pavel Pisa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®