From: Sven Schnelle <svens@linux.ibm.com>
To: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] s390: disable -Warray-bounds
Date: Fri, 22 Apr 2022 15:43:08 +0200 [thread overview]
Message-ID: <20220422134308.1613610-1-svens@linux.ibm.com> (raw)
gcc-12 shows a lot of array bound warnings on s390. This is caused
by our S390_lowcore macro:
which uses an hardcoded address of 0. Wrapping that with
absolute_pointer() works, but gcc no longer knows that a 12 bit
instruction is sufficient to access lowcore. So it emits instructions
like 'lghi %r1,0; l %rx,xxx(%r1)' instead of a single load/store
instruction. As s390 stores variables often read/written in lowcore,
this is considered problematic. Therefore disable -Warray-bounds on
s390 for now until there is a better real solution.
Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
---
arch/s390/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/s390/Makefile b/arch/s390/Makefile
index e441b60b1812..aff0f66e25fb 100644
--- a/arch/s390/Makefile
+++ b/arch/s390/Makefile
@@ -14,6 +14,7 @@ KBUILD_AFLAGS_MODULE += -fPIC
KBUILD_CFLAGS_MODULE += -fPIC
KBUILD_AFLAGS += -m64
KBUILD_CFLAGS += -m64
+KBUILD_CFLAGS += $(call cc-disable-warning, array-bounds)
ifeq ($(CONFIG_RELOCATABLE),y)
KBUILD_CFLAGS += -fPIE
LDFLAGS_vmlinux := -pie
@@ -28,6 +29,7 @@ KBUILD_CFLAGS_DECOMPRESSOR += -fno-asynchronous-unwind-tables
KBUILD_CFLAGS_DECOMPRESSOR += -ffreestanding
KBUILD_CFLAGS_DECOMPRESSOR += -fno-stack-protector
KBUILD_CFLAGS_DECOMPRESSOR += $(call cc-disable-warning, address-of-packed-member)
+KBUILD_CFLAGS_DECOMPRESSOR += $(call cc-disable-warning, array-bounds)
KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO),-g)
KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO_DWARF4), $(call cc-option, -gdwarf-4,))
UTS_MACHINE := s390x
--
2.35.1
next reply other threads:[~2022-04-22 13:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:43 Sven Schnelle [this message]
2022-04-22 17:54 ` Kees Cook
2022-04-25 9:13 ` Heiko Carstens
2022-06-08 20:07 ` Linus Torvalds
2022-06-08 21:33 ` Kees Cook
2022-06-08 23:59 ` Linus Torvalds
2022-06-09 0:39 ` Kees Cook
2022-06-09 1:22 ` Linus Torvalds
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 13:02 ` Kees Cook
2022-06-09 14:14 ` David Howells
2022-06-09 18:20 ` Linus Torvalds
2022-06-09 23:59 ` Dave Chinner
2022-06-10 1:18 ` Linus Torvalds
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 14:55 ` Nathan Chancellor
2022-06-09 18:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220422134308.1613610-1-svens@linux.ibm.com \
--to=svens@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®