From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, dchinner@redhat.com,
Kees Cook <keescook@chromium.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Sven Schnelle <svens@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: disable -Warray-bounds
Date: Thu, 09 Jun 2022 15:14:39 +0100 [thread overview]
Message-ID: <4147483.1654784079@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com>
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > Yeah. Happily, this has already been solved, but it looks like David didn't do a pull yet for it?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=fscache-next
>
> Good.
Do you want it tagging and a pull req generating, even though it's a single
patch?
Note that Dave Chinner would rather I converted code like:
struct myfs_inode *myfsinode = xyz;
myfsinode->netfs.inode.i_ino = 123;
to something like:
struct myfs_inode *myfsinode = xyz;
struct inode *inode = VFS_I(myfsinode);
inode->i_ino = 123;
where the translation is wrapped inside a VFS_I() macro in every filesystem
and wants this across all filesystems. I think the former looks cleaner, but
he has a point about how to deal with yet another layer of wrapping being
inserted in the future. Do you have a preference?
David
next prev parent reply other threads:[~2022-06-09 14:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:43 Sven Schnelle
2022-04-22 17:54 ` Kees Cook
2022-04-25 9:13 ` Heiko Carstens
2022-06-08 20:07 ` Linus Torvalds
2022-06-08 21:33 ` Kees Cook
2022-06-08 23:59 ` Linus Torvalds
2022-06-09 0:39 ` Kees Cook
2022-06-09 1:22 ` Linus Torvalds
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 13:02 ` Kees Cook
2022-06-09 14:14 ` David Howells [this message]
2022-06-09 18:20 ` Linus Torvalds
2022-06-09 23:59 ` Dave Chinner
2022-06-10 1:18 ` Linus Torvalds
2022-06-09 9:56 ` Philipp Zabel
2022-06-09 14:55 ` Nathan Chancellor
2022-06-09 18:51 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4147483.1654784079@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=dchinner@redhat.com \
--cc=festevam@gmail.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=svens@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®