From: Solomon Tan <wjsota@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Subject: [PATCH 3/7] staging: rtl8192e: Remove unnecessary u8 cast in comparison
Date: Sat, 23 Apr 2022 21:01:46 +0800 [thread overview]
Message-ID: <20220423130150.161903-4-wjsota@gmail.com> (raw)
In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com>
Since the macro VERSION_8190_BD is defined to be 0x3, and the structure
members card_8192_version and IC_Cut are both u8, an explicit u8 cast is
unnecessary.
Signed-off-by: Solomon Tan <wjsota@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index 4fe806eae5b7..b608540c036c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -811,7 +811,7 @@ bool rtl92e_start_adapter(struct net_device *dev)
rtl92e_config_mac(dev);
- if (priv->card_8192_version > (u8)VERSION_8190_BD) {
+ if (priv->card_8192_version > VERSION_8190_BD) {
rtl92e_get_tx_power(dev);
rtl92e_set_tx_power(dev, priv->chan);
}
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index 1b70c12be365..b7bdbd895e7b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -919,7 +919,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
continue;
switch (CurrentCmd->CmdID) {
case CmdID_SetTxPowerLevel:
- if (priv->IC_Cut > (u8)VERSION_8190_BD)
+ if (priv->IC_Cut > VERSION_8190_BD)
_rtl92e_set_tx_power_level(dev,
channel);
break;
--
2.36.0
next prev parent reply other threads:[~2022-04-23 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 13:01 [PATCH 0/7] staging: rtl8192e: Remove unnecessary u8 and u16 casts Solomon Tan
2022-04-23 13:01 ` [PATCH 1/7] staging: rtl8192e: Remove unnecessary u8 assignment cast Solomon Tan
2022-04-23 13:01 ` [PATCH 2/7] staging: rtl8192e: Remove unnecessary u8 argument cast Solomon Tan
2022-04-23 13:01 ` Solomon Tan [this message]
2022-04-23 13:01 ` [PATCH 4/7] staging: rtl8192e: Remove unnecessary u16 assignment cast Solomon Tan
2022-04-23 13:01 ` [PATCH 5/7] staging: rtl8192e: Remove unnecessary u16 argument cast Solomon Tan
2022-04-23 13:01 ` [PATCH 6/7] staging: rtl8192e: Remove u16 cast for u32 parameter Solomon Tan
2022-04-23 13:01 ` [PATCH 7/7] staging: rtl8192e: Remove u16 cast for u16 return value Solomon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423130150.161903-4-wjsota@gmail.com \
--to=wjsota@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®