From: Solomon Tan <wjsota@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
dan.carpenter@oracle.com
Subject: [PATCH 6/7] staging: rtl8192e: Remove u16 cast for u32 parameter
Date: Sat, 23 Apr 2022 21:01:49 +0800 [thread overview]
Message-ID: <20220423130150.161903-7-wjsota@gmail.com> (raw)
In-Reply-To: <20220423130150.161903-1-wjsota@gmail.com>
The explicit u16 cast is not necessary because rtl92e_eeprom_read's
second parameter is defined to be u32.
Signed-off-by: Solomon Tan <wjsota@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index feddb15bccbe..4b9249195b5a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -320,7 +320,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
priv->eeprom_did = rtl92e_eeprom_read(dev, EEPROM_DID >> 1);
usValue = rtl92e_eeprom_read(dev,
- (u16)(EEPROM_Customer_ID>>1)) >> 8;
+ (EEPROM_Customer_ID >> 1)) >> 8;
priv->eeprom_CustomerID = usValue & 0xff;
usValue = rtl92e_eeprom_read(dev,
EEPROM_ICVersion_ChannelPlan>>1);
--
2.36.0
next prev parent reply other threads:[~2022-04-23 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 13:01 [PATCH 0/7] staging: rtl8192e: Remove unnecessary u8 and u16 casts Solomon Tan
2022-04-23 13:01 ` [PATCH 1/7] staging: rtl8192e: Remove unnecessary u8 assignment cast Solomon Tan
2022-04-23 13:01 ` [PATCH 2/7] staging: rtl8192e: Remove unnecessary u8 argument cast Solomon Tan
2022-04-23 13:01 ` [PATCH 3/7] staging: rtl8192e: Remove unnecessary u8 cast in comparison Solomon Tan
2022-04-23 13:01 ` [PATCH 4/7] staging: rtl8192e: Remove unnecessary u16 assignment cast Solomon Tan
2022-04-23 13:01 ` [PATCH 5/7] staging: rtl8192e: Remove unnecessary u16 argument cast Solomon Tan
2022-04-23 13:01 ` Solomon Tan [this message]
2022-04-23 13:01 ` [PATCH 7/7] staging: rtl8192e: Remove u16 cast for u16 return value Solomon Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220423130150.161903-7-wjsota@gmail.com \
--to=wjsota@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®