* [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568
@ 2022-05-02 6:45 Michael Riesch
2022-05-02 9:54 ` Peter Geis
0 siblings, 1 reply; 3+ messages in thread
From: Michael Riesch @ 2022-05-02 6:45 UTC (permalink / raw)
To: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Cc: Rob Herring, Krzysztof Kozlowski, Heiko Stuebner, Michael Riesch,
Liang Chen, Peter Geis, Nicolas Frattaroli, Frank Wunderlich
This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD
operation. Enable it in the device tree.
Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
---
v2:
- As pointed out by Nicolas, this is RK3568 specific. Moved change to
rk3568.dtsi.
arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
index 5eafddf62edc..bbfe8f3d68b7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
@@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
};
&usb_host0_xhci {
+ dr_mode = "otg";
phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
phy-names = "usb2-phy", "usb3-phy";
};
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568
2022-05-02 6:45 [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568 Michael Riesch
@ 2022-05-02 9:54 ` Peter Geis
2022-05-09 9:49 ` Michael Riesch
0 siblings, 1 reply; 3+ messages in thread
From: Peter Geis @ 2022-05-02 9:54 UTC (permalink / raw)
To: Michael Riesch
Cc: devicetree, arm-mail-list, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Liang Chen, Nicolas Frattaroli, Frank Wunderlich
On Mon, May 2, 2022 at 2:46 AM Michael Riesch
<michael.riesch@wolfvision.net> wrote:
>
> This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD
> operation. Enable it in the device tree.
I think I missed a conversation here, the xhci0 controller is the otg
port for both rk3566 and rk3568. The only difference is on rk3566 it
is a usb2 only controller, where on rk3568 it is also a usb3
controller. It was set to host only because my original phy patches
didn't support otg mode. Since then Samuel's series fixed that.
Your original patch was correct.
Always,
Peter
>
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
> ---
> v2:
> - As pointed out by Nicolas, this is RK3568 specific. Moved change to
> rk3568.dtsi.
>
> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> index 5eafddf62edc..bbfe8f3d68b7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
> @@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
> };
>
> &usb_host0_xhci {
> + dr_mode = "otg";
> phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
> phy-names = "usb2-phy", "usb3-phy";
> };
> --
> 2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568
2022-05-02 9:54 ` Peter Geis
@ 2022-05-09 9:49 ` Michael Riesch
0 siblings, 0 replies; 3+ messages in thread
From: Michael Riesch @ 2022-05-09 9:49 UTC (permalink / raw)
To: Peter Geis
Cc: devicetree, arm-mail-list, open list:ARM/Rockchip SoC...,
Linux Kernel Mailing List, Rob Herring, Krzysztof Kozlowski,
Heiko Stuebner, Liang Chen, Nicolas Frattaroli, Frank Wunderlich
Hello Peter,
On 5/2/22 11:54, Peter Geis wrote:
> On Mon, May 2, 2022 at 2:46 AM Michael Riesch
> <michael.riesch@wolfvision.net> wrote:
>>
>> This USB 3.0 controller of the Rockchip RK3568 is capable of OTG/DRD
>> operation. Enable it in the device tree.
>
> I think I missed a conversation here, the xhci0 controller is the otg
> port for both rk3566 and rk3568. The only difference is on rk3566 it
> is a usb2 only controller, where on rk3568 it is also a usb3
> controller. It was set to host only because my original phy patches
> didn't support otg mode. Since then Samuel's series fixed that.
>
> Your original patch was correct.
I have already replied to v1, but at this point I would like to
- thank you for pointing this out
- and send a friendly reminder to Heiko: please apply v1 of this
patch :-)
Thanks and best regards,
Michael
>
> Always,
> Peter
>
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>> v2:
>> - As pointed out by Nicolas, this is RK3568 specific. Moved change to
>> rk3568.dtsi.
>>
>> arch/arm64/boot/dts/rockchip/rk3568.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3568.dtsi b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> index 5eafddf62edc..bbfe8f3d68b7 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568.dtsi
>> @@ -134,6 +134,7 @@ power-domain@RK3568_PD_PIPE {
>> };
>>
>> &usb_host0_xhci {
>> + dr_mode = "otg";
>> phys = <&usb2phy0_otg>, <&combphy0 PHY_TYPE_USB3>;
>> phy-names = "usb2-phy", "usb3-phy";
>> };
>> --
>> 2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-09 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 6:45 [PATCH v2] arm64: dts: rockchip: enable otg/drd operation of usb_host0_xhci in rk3568 Michael Riesch
2022-05-02 9:54 ` Peter Geis
2022-05-09 9:49 ` Michael Riesch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®