From: "Michal Koutný" <mkoutny@suse.com>
To: "T.J. Mercier" <tjmercier@google.com>
Cc: "Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Hridya Valsaraju" <hridya@google.com>,
"Christian König" <christian.koenig@amd.com>,
"John Stultz" <jstultz@google.com>,
"Todd Kjos" <tkjos@android.com>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Kalesh Singh" <kaleshsingh@google.com>,
Kenny.Ho@amd.com, "Shuah Khan" <skhan@linuxfoundation.org>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v6 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory
Date: Thu, 5 May 2022 13:50:15 +0200 [thread overview]
Message-ID: <20220505115015.GD10890@blackbody.suse.cz> (raw)
In-Reply-To: <CABdmKX2DJy0i3XAP7xTduZ8KFVKtgto24w714YJNUb_=pfYiKw@mail.gmail.com>
On Wed, May 04, 2022 at 10:19:20AM -0700, "T.J. Mercier" <tjmercier@google.com> wrote:
> Should I export these now for this series?
Hehe, _I_ don't know.
Depends on the likelihood this lands in and is built upon.
> No, except maybe the gpucg_bucket name which I can add an accessor
> function for. Won't this mean depending on LTO for potential inlining
> of the functions currently implemented in the header?
Yes. Also depends how much inlining here would be performance relevant.
I suggested this with an OS vendor hat on, i.e. the less such ABI, the
simpler.
> I'm happy to make this change, but I wonder why some parts of the
> kernel take this approach and others do not.
I think there is no convention (see also
Documentation/process/stable-api-nonsense.rst ;-)).
Regards,
Michal
next prev parent reply other threads:[~2022-05-05 11:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 23:19 [PATCH v6 0/6] Proposal for a GPU cgroup controller T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 1/6] gpu: rfc: " T.J. Mercier
2022-05-04 12:10 ` Michal Koutný
2022-05-04 17:16 ` T.J. Mercier
2022-05-05 11:29 ` Michal Koutný
2022-05-05 23:56 ` T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 2/6] cgroup: gpu: Add a cgroup controller for allocator attribution of GPU memory T.J. Mercier
2022-05-04 12:25 ` Michal Koutný
2022-05-04 17:19 ` T.J. Mercier
2022-05-05 11:50 ` Michal Koutný [this message]
2022-05-05 23:56 ` T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 3/6] dmabuf: heaps: export system_heap buffers with GPU cgroup charging T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 4/6] dmabuf: Add gpu cgroup charge transfer function T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 5/6] binder: Add flags to relinquish ownership of fds T.J. Mercier
2022-05-02 23:19 ` [PATCH v6 6/6] selftests: Add binder cgroup gpu memory transfer tests T.J. Mercier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505115015.GD10890@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=Kenny.Ho@amd.com \
--cc=cgroups@vger.kernel.org \
--cc=christian.koenig@amd.com \
--cc=cmllamas@google.com \
--cc=daniel@ffwll.ch \
--cc=hannes@cmpxchg.org \
--cc=hridya@google.com \
--cc=jstultz@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=skhan@linuxfoundation.org \
--cc=surenb@google.com \
--cc=tj@kernel.org \
--cc=tjmercier@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®