* [PATCH] ARM: mstar: Fix refcount leaks
@ 2022-05-12 3:46 Miaoqian Lin
2022-05-18 6:29 ` Romain Perier
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-12 3:46 UTC (permalink / raw)
To: Daniel Palmer, Romain Perier, Russell King, Arnd Bergmann,
linux-arm-kernel, linux-kernel
Cc: linmq006
of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.
Fixes: 5919eec0f092 ("ARM: mstar: SMP support")
Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-mstar/mstarv7.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-mstar/mstarv7.c b/arch/arm/mach-mstar/mstarv7.c
index 274c4f0df270..3176998817d2 100644
--- a/arch/arm/mach-mstar/mstarv7.c
+++ b/arch/arm/mach-mstar/mstarv7.c
@@ -86,6 +86,7 @@ static int mstarv7_boot_secondary(unsigned int cpu, struct task_struct *idle)
np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl");
smpctrl = of_iomap(np, 0);
+ of_node_put(np);
if (!smpctrl)
return -ENODEV;
@@ -120,6 +121,7 @@ static void __init mstarv7_init(void)
soc_mb = mstarv7_mb;
else
pr_warn("Failed to install memory barrier, DMA will be broken!\n");
+ of_node_put(np);
}
DT_MACHINE_START(MSTARV7_DT, "MStar/Sigmastar Armv7 (Device Tree)")
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: mstar: Fix refcount leaks
2022-05-12 3:46 [PATCH] ARM: mstar: Fix refcount leaks Miaoqian Lin
@ 2022-05-18 6:29 ` Romain Perier
0 siblings, 0 replies; 2+ messages in thread
From: Romain Perier @ 2022-05-18 6:29 UTC (permalink / raw)
To: Miaoqian Lin
Cc: Daniel Palmer, Russell King, Arnd Bergmann, linux-arm-kernel,
Linux Kernel Mailing List
Hi,
Le jeu. 12 mai 2022 à 05:47, Miaoqian Lin <linmq006@gmail.com> a écrit :
>
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 5919eec0f092 ("ARM: mstar: SMP support")
> Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Looks good to me,
Reviewed-by: Romain Perier <romain.perier@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-18 6:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 3:46 [PATCH] ARM: mstar: Fix refcount leaks Miaoqian Lin
2022-05-18 6:29 ` Romain Perier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®