mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tien.sung.ang@intel.com
To: mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com
Cc: linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	tien.sung.ang@intel.com
Subject: Re: [PATCH] fpga: altera-cvp: Truncated bitstream error support
Date: Thu, 19 May 2022 17:39:07 +0800	[thread overview]
Message-ID: <20220519093907.2883394-1-tien.sung.ang@intel.com> (raw)
In-Reply-To: <b0fd6c41-f8a4-bb3a-d05a-2ea17d4ffc80@redhat.com>

Thanks for bringing this up. Yes, you are right that the fpga_mgr sees this
as an error irrespective of the value. The CvP driver is changed now to just
indicate the correct error which recommends a retry. To me understanding,
EAGAIN was this. The fpga manager now looks like is going to return a CvP
failure in short. 
A BUSY state does not seem to be able to solve this issue. 
Even an extended time-out didn't resolve this error state. The current time-out
is set to 10seconds.   
However, the main objective is to also handle the error if the CvP firmware
is not responsive. The error_path flow is to reset the CVP mode and HIP_CLK_SEL bit
as recommended by the firmware engineers. 
The flow prescribed here is also an identical copy of working CvP driver 
which is also owned by Intel. This driver is a downstream driver which is 
not part of the Linux kernel. We are now porting this differences over to 
the current upstream CvP driver. 

  reply	other threads:[~2022-05-19  9:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  7:38 [PATCH] fpga: altera-cvp: allow interrupt to continue next time tien.sung.ang
2022-05-18 14:04 ` Tom Rix
2022-05-19  9:39   ` tien.sung.ang [this message]
2022-05-28 12:05     ` [PATCH] fpga: altera-cvp: Truncated bitstream error support Xu Yilun
2022-06-01  1:40       ` [PATCH v2] fpga: altera-cvp: allow interrupt to continue next time tien.sung.ang
2022-06-03 11:00         ` Xu Yilun
2022-05-28 12:04 ` [PATCH] " Xu Yilun
2022-05-31  2:20   ` tien.sung.ang
2022-06-03 10:14     ` Xu Yilun
  -- strict thread matches above, loose matches on Subject: below --
2022-05-18  6:48 [PATCH] fpga: altera-cvp: Truncated bitstream error support tien.sung.ang
2022-05-18 20:08 ` Tom Rix
2022-05-19  4:34   ` tien.sung.ang
2022-05-28 10:01     ` Xu Yilun
2022-05-28 10:03   ` Xu Yilun
2022-05-18 20:54 ` Christophe JAILLET
2022-05-19  4:21   ` tien.sung.ang
2022-05-28 10:08     ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519093907.2883394-1-tien.sung.ang@intel.com \
    --to=tien.sung.ang@intel.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®