mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tien.sung.ang@intel.com
To: yilun.xu@intel.com
Cc: hao.wu@intel.com, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, mdf@kernel.org,
	tien.sung.ang@intel.com, trix@redhat.com, dinh.nguyen@intel.com
Subject: [PATCH v2] fpga: altera-cvp: allow interrupt to continue next time
Date: Wed,  1 Jun 2022 09:40:27 +0800	[thread overview]
Message-ID: <20220601014027.2547481-1-tien.sung.ang@intel.com> (raw)
In-Reply-To: <20220528120503.GB175058@yilunxu-OptiPlex-7050>

From: Dinh Nguyen <dinh.nguyen@intel.com>

The main objective of this change is to perform error handling
if the CvP firmware becomes unresponsive. The error_path flow
resets the CvP mode and HIP_CLK_SEL bit.

CFG_READY signal/bit may time-out due to firmware not responding
within the given time-out. This time varies due to numerous
factors like size of bitstream and others.
This time-out error may or may not impact the result of the CvP
previous transactions. The CvP driver shall then, respond with
EAGAIN instead Time out error.

Signed-off-by: Dinh Nguyen <dinh.nguyen@intel.com>
Signed-off-by: Ang Tien Sung <tien.sung.ang@intel.com>
---

changelog v2:
* Amend the commit message

---
 drivers/fpga/altera-cvp.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c
index 4ffb9da537d8..d74ff63c61e8 100644
--- a/drivers/fpga/altera-cvp.c
+++ b/drivers/fpga/altera-cvp.c
@@ -309,10 +309,22 @@ static int altera_cvp_teardown(struct fpga_manager *mgr,
 	/* STEP 15 - poll CVP_CONFIG_READY bit for 0 with 10us timeout */
 	ret = altera_cvp_wait_status(conf, VSE_CVP_STATUS_CFG_RDY, 0,
 				     conf->priv->poll_time_us);
-	if (ret)
+	if (ret) {
 		dev_err(&mgr->dev, "CFG_RDY == 0 timeout\n");
+		goto error_path;
+	}
 
 	return ret;
+
+error_path:
+	/* reset CVP_MODE and HIP_CLK_SEL bit */
+	altera_read_config_dword(conf, VSE_CVP_MODE_CTRL, &val);
+	val &= ~VSE_CVP_MODE_CTRL_HIP_CLK_SEL;
+	val &= ~VSE_CVP_MODE_CTRL_CVP_MODE;
+	altera_write_config_dword(conf, VSE_CVP_MODE_CTRL, val);
+
+	return -EAGAIN;
+
 }
 
 static int altera_cvp_write_init(struct fpga_manager *mgr,
-- 
2.25.1


  reply	other threads:[~2022-06-01  1:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18  7:38 [PATCH] " tien.sung.ang
2022-05-18 14:04 ` Tom Rix
2022-05-19  9:39   ` [PATCH] fpga: altera-cvp: Truncated bitstream error support tien.sung.ang
2022-05-28 12:05     ` Xu Yilun
2022-06-01  1:40       ` tien.sung.ang [this message]
2022-06-03 11:00         ` [PATCH v2] fpga: altera-cvp: allow interrupt to continue next time Xu Yilun
2022-05-28 12:04 ` [PATCH] " Xu Yilun
2022-05-31  2:20   ` tien.sung.ang
2022-06-03 10:14     ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601014027.2547481-1-tien.sung.ang@intel.com \
    --to=tien.sung.ang@intel.com \
    --cc=dinh.nguyen@intel.com \
    --cc=hao.wu@intel.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®