* [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind
@ 2022-05-25 11:54 Miaoqian Lin
2022-06-27 7:59 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-25 11:54 UTC (permalink / raw)
To: Linus Walleij, David Airlie, Daniel Vetter, dri-devel, linux-kernel
Cc: linmq006
Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.
Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/mcde/mcde_dsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 5651734ce977..9f9ac8699310 100644
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
bridge = of_drm_find_bridge(child);
if (!bridge) {
dev_err(dev, "failed to find bridge\n");
+ of_node_put(child);
return -EINVAL;
}
}
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind
2022-05-25 11:54 [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind Miaoqian Lin
@ 2022-06-27 7:59 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-06-27 7:59 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On Wed, May 25, 2022 at 1:54 PM Miaoqian Lin <linmq006@gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference counter of the previous node. There is no decrement
> when break out from the loop and results in refcount leak.
> Add missing of_node_put() to fix this.
>
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Patch applied for next as nonurgent fix.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-27 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-25 11:54 [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind Miaoqian Lin
2022-06-27 7:59 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®