From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
"Paul E . McKenney" <paulmck@kernel.org>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Phil Auld <pauld@redhat.com>, Zefan Li <lizefan.x@bytedance.com>,
Waiman Long <longman@redhat.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
rcu@vger.kernel.org
Subject: Re: [PATCH 1/4] rcu/nocb: Pass a cpumask instead of a single CPU to offload/deoffload
Date: Thu, 26 May 2022 00:19:17 +0200 [thread overview]
Message-ID: <20220525221917.GA1151462@lothringen> (raw)
In-Reply-To: <20220525221055.1152307-2-frederic@kernel.org>
On Thu, May 26, 2022 at 12:10:52AM +0200, Frederic Weisbecker wrote:
> @@ -1117,12 +1111,6 @@ static long rcu_nocb_rdp_offload(void *arg)
> struct rcu_data *rdp_gp = rdp->nocb_gp_rdp;
>
> WARN_ON_ONCE(rdp->cpu != raw_smp_processor_id());
> - /*
> - * For now we only support re-offload, ie: the rdp must have been
> - * offloaded on boot first.
> - */
> - if (!rdp->nocb_gp_rdp)
> - return -EINVAL;
>
> if (WARN_ON_ONCE(!rdp_gp->nocb_gp_kthread))
> return -EINVAL;
And why did I remove this critical check? I have no answer...
next prev parent reply other threads:[~2022-05-25 22:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 22:10 [PATCH 0/4] rcu/cpuset: Control RCU_NOCB offloading through cpusets Frederic Weisbecker
2022-05-25 22:10 ` [PATCH 1/4] rcu/nocb: Pass a cpumask instead of a single CPU to offload/deoffload Frederic Weisbecker
2022-05-25 22:19 ` Frederic Weisbecker [this message]
2022-05-25 22:42 ` Paul E. McKenney
2022-05-25 22:10 ` [PATCH 2/4] rcu/nocb: Prepare to change nocb cpumask from CPU-hotplug protected cpuset caller Frederic Weisbecker
2022-05-25 22:10 ` [PATCH 3/4] sched/isolation: Infrastructure to support rcu nocb cpumask changes Frederic Weisbecker
2022-08-19 7:12 ` Tobias Huschle
2022-05-25 22:10 ` [RFC PATCH 4/4] cpuset: Support RCU-NOCB toggle on v2 root partitions Frederic Weisbecker
2022-05-26 18:21 ` Tejun Heo
2022-05-26 22:51 ` Frederic Weisbecker
2022-05-26 23:02 ` Tejun Heo
2022-05-27 0:28 ` Waiman Long
2022-05-27 0:37 ` Tejun Heo
2022-05-27 8:30 ` Juri Lelli
2022-05-27 8:45 ` Tejun Heo
2022-05-27 12:58 ` Phil Auld
2022-05-28 14:24 ` Peter Zijlstra
2022-05-30 0:40 ` Frederic Weisbecker
2022-05-30 8:11 ` Peter Zijlstra
2022-05-30 10:56 ` Frederic Weisbecker
2022-05-30 13:16 ` Peter Zijlstra
2022-05-30 14:13 ` Juri Lelli
2022-05-30 21:35 ` Frederic Weisbecker
2022-05-31 0:57 ` Tejun Heo
2022-05-31 14:21 ` Waiman Long
2022-05-30 14:29 ` nicolas saenz julienne
2022-05-30 14:49 ` Paul E. McKenney
2022-05-30 22:36 ` Alison Chaiken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220525221917.GA1151462@lothringen \
--to=frederic@kernel.org \
--cc=bristot@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=mtosatti@redhat.com \
--cc=nsaenz@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=pauld@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome