* [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of
@ 2022-05-26 8:17 Miaoqian Lin
2022-06-03 22:08 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-26 8:17 UTC (permalink / raw)
To: Linus Walleij, Russell King, linux-arm-kernel, linux-kernel; +Cc: linmq006
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
arch/arm/mach-integrator/integrator_cp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-integrator/integrator_cp.c b/arch/arm/mach-integrator/integrator_cp.c
index b7eb4038798b..bb301ca8c7e1 100644
--- a/arch/arm/mach-integrator/integrator_cp.c
+++ b/arch/arm/mach-integrator/integrator_cp.c
@@ -126,6 +126,7 @@ static void __init intcp_init_of(void)
return;
intcp_con_base = of_iomap(cpcon, 0);
+ of_node_put(cpcon);
if (!intcp_con_base)
return;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of
2022-05-26 8:17 [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of Miaoqian Lin
@ 2022-06-03 22:08 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2022-06-03 22:08 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: Russell King, linux-arm-kernel, linux-kernel
On Thu, May 26, 2022 at 10:18 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Patch applied manually (target file moved in the tree)
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-03 22:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-26 8:17 [PATCH] ARM: integrator: Fix refcount leak in intcp_init_of Miaoqian Lin
2022-06-03 22:08 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®