From: Steven Rostedt <rostedt@goodmis.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "printk: wake up all waiters"
Date: Thu, 26 May 2022 16:37:10 -0400 [thread overview]
Message-ID: <20220526163710.0a2cd6f4@gandalf.local.home> (raw)
In-Reply-To: <20220526203056.81123-1-john.ogness@linutronix.de>
On Thu, 26 May 2022 22:36:56 +0206
John Ogness <john.ogness@linutronix.de> wrote:
> This reverts commit 938ba4084abcf6fdd21d9078513c52f8fb9b00d0.
>
> The wait queue @log_wait never has exclusive waiters, so there
> is no need to use wake_up_interruptible_all(). Using
> wake_up_interruptible() was the correct function to wake all
> waiters.
>
> Since there are no exclusive waiters, erroneously changing
> wake_up_interruptible() to wake_up_interruptible_all() did not
> result in any behavior change. However, using
> wake_up_interruptible_all() on a wait queue without exclusive
> waiters is fundamentally wrong.
>
> Go back to using wake_up_interruptible() to wake all waiters.
(Just to show that I have been paying attention ;-)
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
> ---
> kernel/printk/printk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index a3e1035929b0..ea3dd55709e7 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -3904,7 +3904,7 @@ static void wake_up_klogd_work_func(struct irq_work *irq_work)
> }
>
> if (pending & PRINTK_PENDING_WAKEUP)
> - wake_up_interruptible_all(&log_wait);
> + wake_up_interruptible(&log_wait);
> }
>
> static DEFINE_PER_CPU(struct irq_work, wake_up_klogd_work) =
next prev parent reply other threads:[~2022-05-26 20:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 20:30 John Ogness
2022-05-26 20:37 ` Steven Rostedt [this message]
2022-05-27 12:52 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220526163710.0a2cd6f4@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®