mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "printk: wake up all waiters"
Date: Fri, 27 May 2022 14:52:06 +0200	[thread overview]
Message-ID: <YpDJduWln8D8Or6y@alley> (raw)
In-Reply-To: <20220526203056.81123-1-john.ogness@linutronix.de>

On Thu 2022-05-26 22:36:56, John Ogness wrote:
> This reverts commit 938ba4084abcf6fdd21d9078513c52f8fb9b00d0.
> 
> The wait queue @log_wait never has exclusive waiters, so there
> is no need to use wake_up_interruptible_all(). Using
> wake_up_interruptible() was the correct function to wake all
> waiters.
> 
> Since there are no exclusive waiters, erroneously changing
> wake_up_interruptible() to wake_up_interruptible_all() did not
> result in any behavior change. However, using
> wake_up_interruptible_all() on a wait queue without exclusive
> waiters is fundamentally wrong.
> 
> Go back to using wake_up_interruptible() to wake all waiters.
> 
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

The patch has been committed into printk/linux.git, branch
rework/printk.

I am going to create the pull request the following week
after it gets at least one spin in linux-next.

It is trivial patch so that it might be sent directly.
But it does not affect the functionality and is is not
urgent either.

Best Regards,
Petr

      parent reply	other threads:[~2022-05-27 12:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-26 20:30 John Ogness
2022-05-26 20:37 ` Steven Rostedt
2022-05-27 12:52 ` Petr Mladek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpDJduWln8D8Or6y@alley \
    --to=pmladek@suse.com \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®