* [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value
@ 2022-05-22 6:18 Gautam Menghani
2022-05-25 15:25 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Gautam Menghani @ 2022-05-22 6:18 UTC (permalink / raw)
To: rostedt, mingo; +Cc: Gautam Menghani, linux-kernel, linux-kernel-mentees, skhan
Initialize the integer variable to 0 to fix the clang scan warning:
Undefined or garbage value returned to caller
[core.uninitialized.UndefReturn]
return ret;
Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
---
kernel/trace/trace_boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
index 0580287d7a0d..778200dd8ede 100644
--- a/kernel/trace/trace_boot.c
+++ b/kernel/trace/trace_boot.c
@@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
{
struct xbc_node *node;
const char *p, *handler;
- int ret;
+ int ret = 0;
handler = xbc_node_get_data(hnode);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value
2022-05-22 6:18 [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value Gautam Menghani
@ 2022-05-25 15:25 ` Steven Rostedt
2022-05-26 14:54 ` Masami Hiramatsu
0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2022-05-25 15:25 UTC (permalink / raw)
To: Gautam Menghani
Cc: mingo, linux-kernel, linux-kernel-mentees, skhan, Masami Hiramatsu
On Sat, 21 May 2022 23:18:26 -0700
Gautam Menghani <gautammenghani201@gmail.com> wrote:
> Initialize the integer variable to 0 to fix the clang scan warning:
> Undefined or garbage value returned to caller
> [core.uninitialized.UndefReturn]
> return ret;
>
> Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> ---
> kernel/trace/trace_boot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> index 0580287d7a0d..778200dd8ede 100644
> --- a/kernel/trace/trace_boot.c
> +++ b/kernel/trace/trace_boot.c
> @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> {
> struct xbc_node *node;
> const char *p, *handler;
> - int ret;
> + int ret = 0;
Looks good to me. Masami, care to ack it?
-- Steve
>
> handler = xbc_node_get_data(hnode);
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value
2022-05-25 15:25 ` Steven Rostedt
@ 2022-05-26 14:54 ` Masami Hiramatsu
0 siblings, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2022-05-26 14:54 UTC (permalink / raw)
To: Steven Rostedt
Cc: Gautam Menghani, mingo, linux-kernel, linux-kernel-mentees,
skhan, Masami Hiramatsu
On Wed, 25 May 2022 11:25:51 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sat, 21 May 2022 23:18:26 -0700
> Gautam Menghani <gautammenghani201@gmail.com> wrote:
>
> > Initialize the integer variable to 0 to fix the clang scan warning:
> > Undefined or garbage value returned to caller
> > [core.uninitialized.UndefReturn]
> > return ret;
> >
> > Signed-off-by: Gautam Menghani <gautammenghani201@gmail.com>
> > ---
> > kernel/trace/trace_boot.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_boot.c b/kernel/trace/trace_boot.c
> > index 0580287d7a0d..778200dd8ede 100644
> > --- a/kernel/trace/trace_boot.c
> > +++ b/kernel/trace/trace_boot.c
> > @@ -300,7 +300,7 @@ trace_boot_hist_add_handlers(struct xbc_node *hnode, char **bufp,
> > {
> > struct xbc_node *node;
> > const char *p, *handler;
> > - int ret;
> > + int ret = 0;
>
> Looks good to me. Masami, care to ack it?
Thanks! This looks good to me.
Fixes: 8993665abcce ("tracing/boot: Support multiple handlers for per-event histogram")
Cc: stable@vger.kernel.org
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Thank you!
>
> -- Steve
>
> >
> > handler = xbc_node_get_data(hnode);
> >
>
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-26 14:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-22 6:18 [PATCH] kernel/trace: Initialize integer variable to prevent garbage return value Gautam Menghani
2022-05-25 15:25 ` Steven Rostedt
2022-05-26 14:54 ` Masami Hiramatsu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®