* Re: [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX()
@ 2022-05-27 8:04 Christophe JAILLET
2022-05-27 10:19 ` Michael S. Tsirkin
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2022-05-27 8:04 UTC (permalink / raw)
To: kch
Cc: jasowang, linux-block, mst, pbonzini, stefanha, virtualization,
keliu, linux-kernel
(Resend, my email client sent it as HTML. So sorry for the duplicate)
Hi,
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 74c3a48cd1e5..e05748337dd1 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -720,8 +720,8 @@ static int virtblk_probe(struct virtio_device *vdev)
> return -EINVAL;
> }
>
>- err = ida_simple_get(&vd_index_ida, 0, minor_to_index(1 << MINORBITS),
>- GFP_KERNEL);
>+ err = ida_alloc_max(&vd_index_ida, minor_to_index(1 << MINORBITS),
>+ GFP_KERNEL);
> if (err < 0)
> goto out;
> index = err;
this patch, already applied to -next, is wrong.
The upper bound of ida_simple_get() is exlcusive, while the one of
ida_alloc_max() is inclusive.
So, 'minor_to_index(1 << MINORBITS)' should be 'minor_to_index(1 <<
MINORBITS) - 1' here.
(adding keliu in cc: because he is proposing the same kind of patches,
so he will see how to to these changes that are slighly tricky)
CJ
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX()
2022-05-27 8:04 [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX() Christophe JAILLET
@ 2022-05-27 10:19 ` Michael S. Tsirkin
0 siblings, 0 replies; 2+ messages in thread
From: Michael S. Tsirkin @ 2022-05-27 10:19 UTC (permalink / raw)
To: Christophe JAILLET
Cc: kch, jasowang, linux-block, pbonzini, stefanha, virtualization,
keliu, linux-kernel
On Fri, May 27, 2022 at 10:04:46AM +0200, Christophe JAILLET wrote:
> (Resend, my email client sent it as HTML. So sorry for the duplicate)
>
>
> Hi,
>
> > diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> > index 74c3a48cd1e5..e05748337dd1 100644
> > --- a/drivers/block/virtio_blk.c
> > +++ b/drivers/block/virtio_blk.c
> > @@ -720,8 +720,8 @@ static int virtblk_probe(struct virtio_device *vdev)
> > return -EINVAL;
> > }
> >
> >- err = ida_simple_get(&vd_index_ida, 0, minor_to_index(1 << MINORBITS),
> >- GFP_KERNEL);
> >+ err = ida_alloc_max(&vd_index_ida, minor_to_index(1 << MINORBITS),
> >+ GFP_KERNEL);
> > if (err < 0)
> > goto out;
> > index = err;
>
>
> this patch, already applied to -next, is wrong.
>
>
> The upper bound of ida_simple_get() is exlcusive, while the one of
> ida_alloc_max() is inclusive.
>
> So, 'minor_to_index(1 << MINORBITS)' should be 'minor_to_index(1 <<
> MINORBITS) - 1' here.
>
>
> (adding keliu in cc: because he is proposing the same kind of patches, so he
> will see how to to these changes that are slighly tricky)
>
>
> CJ
I will drop this for now, please resend with either
a corrected version or a comment explaining why it's correct.
Thanks!
--
MST
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-27 10:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27 8:04 [PATCH 4/4] virtio-blk: remove deprecated ida_simple_XXX() Christophe JAILLET
2022-05-27 10:19 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®