* [PATCH v2] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
@ 2022-06-01 10:55 Miaoqian Lin
2022-06-04 20:49 ` Péter Ujfalusi
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-06-01 10:55 UTC (permalink / raw)
To: dave.jiang, Peter Ujfalusi, Vinod Koul, dmaengine, linux-kernel; +Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.
Add missing of_node_put() in to fix this.
Fixes: ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/20220512051815.11946-1-linmq006@gmail.com
---
drivers/dma/ti/dma-crossbar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 71d24fc07c00..e34cfb50d241 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
mutex_unlock(&xbar->mutex);
dev_err(&pdev->dev, "Run out of free DMA requests\n");
kfree(map);
+ of_node_put(dma_spec->np);
return ERR_PTR(-ENOMEM);
}
set_bit(map->xbar_out, xbar->dma_inuse);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
2022-06-01 10:55 [PATCH v2] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate Miaoqian Lin
@ 2022-06-04 20:49 ` Péter Ujfalusi
0 siblings, 0 replies; 2+ messages in thread
From: Péter Ujfalusi @ 2022-06-04 20:49 UTC (permalink / raw)
To: Miaoqian Lin, dave.jiang, Vinod Koul, dmaengine, linux-kernel
On 01/06/2022 13:55, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not needed anymore.
>
> Add missing of_node_put() in to fix this.
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
>
> Fixes: ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> - split v1 into two patches.
> v1 link: https://lore.kernel.org/r/20220512051815.11946-1-linmq006@gmail.com
> ---
> drivers/dma/ti/dma-crossbar.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
> index 71d24fc07c00..e34cfb50d241 100644
> --- a/drivers/dma/ti/dma-crossbar.c
> +++ b/drivers/dma/ti/dma-crossbar.c
> @@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
> mutex_unlock(&xbar->mutex);
> dev_err(&pdev->dev, "Run out of free DMA requests\n");
> kfree(map);
> + of_node_put(dma_spec->np);
> return ERR_PTR(-ENOMEM);
> }
> set_bit(map->xbar_out, xbar->dma_inuse);
--
Péter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-04 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01 10:55 [PATCH v2] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate Miaoqian Lin
2022-06-04 20:49 ` Péter Ujfalusi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®