[PATCH 1/2] habanalabs: Fix kernel-doc

[PATCH 1/2] habanalabs: Fix kernel-doc

[Jiapeng Chong]

Fix the following W=1 kernel warnings:

drivers/misc/habanalabs/common/pci/pci.c:454: warning: expecting
prototype for hl_fw_fini(). Prototype was for hl_pci_fini() instead.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/misc/habanalabs/common/pci/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/common/pci/pci.c b/drivers/misc/habanalabs/common/pci/pci.c
index 610acd4a8057..d2314157addd 100644
--- a/drivers/misc/habanalabs/common/pci/pci.c
+++ b/drivers/misc/habanalabs/common/pci/pci.c
@@ -445,7 +445,7 @@ int hl_pci_init(struct hl_device *hdev)
 }
 
 /**
- * hl_fw_fini() - PCI finalization code.
+ * hl_pci_fini() - PCI finalization code.
  * @hdev: Pointer to hl_device structure
  *
  * Unmap PCI bars and disable PCI device.
-- 
2.20.1.7.g153144c

[PATCH 2/2] habanalabs: Fix kernel-doc

[Jiapeng Chong]

Fix the following W=1 kernel warnings:

drivers/misc/habanalabs/common/mmu/mmu_v1.c:425: warning: expecting
prototype for hl_mmu_fini(). Prototype was for hl_mmu_v1_fini() instead.

drivers/misc/habanalabs/common/mmu/mmu_v1.c:449: warning: expecting
prototype for hl_mmu_ctx_init(). Prototype was for hl_mmu_v1_ctx_init()
instead.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/misc/habanalabs/common/mmu/mmu_v1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
index e2d91a69acc2..ad4b49281cd7 100644
--- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
+++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
@@ -412,7 +412,7 @@ static int hl_mmu_v1_init(struct hl_device *hdev)
 }
 
 /**
- * hl_mmu_fini() - release the MMU module.
+ * hl_mmu_v1_fini() - release the MMU module.
  * @hdev: habanalabs device structure.
  *
  * This function does the following:
@@ -438,7 +438,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev)
 }
 
 /**
- * hl_mmu_ctx_init() - initialize a context for using the MMU module.
+ * hl_mmu_v1_ctx_init() - initialize a context for using the MMU module.
  * @ctx: pointer to the context structure to initialize.
  *
  * Initialize a mutex to protect the concurrent mapping flow, a hash to hold all
-- 
2.20.1.7.g153144c

Re: [PATCH 2/2] habanalabs: Fix kernel-doc

[Oded Gabbay]

On Thu, Jun 2, 2022 at 6:58 AM Jiapeng Chong
<jiapeng.chong@linux.alibaba.com> wrote:
>
> Fix the following W=1 kernel warnings:
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:425: warning: expecting
> prototype for hl_mmu_fini(). Prototype was for hl_mmu_v1_fini() instead.
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:449: warning: expecting
> prototype for hl_mmu_ctx_init(). Prototype was for hl_mmu_v1_ctx_init()
> instead.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  drivers/misc/habanalabs/common/mmu/mmu_v1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index e2d91a69acc2..ad4b49281cd7 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -412,7 +412,7 @@ static int hl_mmu_v1_init(struct hl_device *hdev)
>  }
>
>  /**
> - * hl_mmu_fini() - release the MMU module.
> + * hl_mmu_v1_fini() - release the MMU module.
>   * @hdev: habanalabs device structure.
>   *
>   * This function does the following:
> @@ -438,7 +438,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev)
>  }
>
>  /**
> - * hl_mmu_ctx_init() - initialize a context for using the MMU module.
> + * hl_mmu_v1_ctx_init() - initialize a context for using the MMU module.
>   * @ctx: pointer to the context structure to initialize.
>   *
>   * Initialize a mutex to protect the concurrent mapping flow, a hash to hold all
> --
> 2.20.1.7.g153144c
>

Both patches are
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>

Applied to -next.
Thanks,
Oded