From: Daniel Thompson <daniel.thompson@linaro.org>
To: Stephen Kitt <steve@sk2.org>
Cc: "Lee, Chun-Yi" <jlee@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Cezary Jackiewicz <cezary.jackiewicz@gmail.com>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] platform/x86: apple-gmux: Use backlight helper
Date: Wed, 8 Jun 2022 16:06:32 +0100 [thread overview]
Message-ID: <20220608150632.mnebepml2cply4px@maple.lan> (raw)
In-Reply-To: <20220607184635.1127913-3-steve@sk2.org>
On Tue, Jun 07, 2022 at 08:46:33PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mark Gross <markgross@kernel.org>
> Cc: platform-driver-x86@vger.kernel.org
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
next prev parent reply other threads:[~2022-06-08 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 18:46 [PATCH 0/4] platform/x86: Use backlight helpers Stephen Kitt
2022-06-07 18:46 ` [PATCH 1/4] platform/x86: acer-wmi: Use backlight helper Stephen Kitt
2022-06-08 15:06 ` Daniel Thompson
2022-06-07 18:46 ` [PATCH 2/4] platform/x86: apple-gmux: " Stephen Kitt
2022-06-08 15:06 ` Daniel Thompson [this message]
2022-06-07 18:46 ` [PATCH 3/4] platform/x86: compal-laptop: " Stephen Kitt
2022-06-08 15:06 ` Daniel Thompson
2022-06-07 18:46 ` [PATCH 4/4] platform/x86: thinkpad_acpi: " Stephen Kitt
2022-06-08 15:07 ` Daniel Thompson
2022-06-22 9:54 ` [PATCH 0/4] platform/x86: Use backlight helpers Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220608150632.mnebepml2cply4px@maple.lan \
--to=daniel.thompson@linaro.org \
--cc=cezary.jackiewicz@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=jlee@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®