From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: James Smart <jsmart2021@gmail.com>,
Justin Tee <justin.tee@broadcom.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Sasha Levin <sashal@kernel.org>,
james.smart@avagotech.com, dick.kennedy@avagotech.com,
jejb@linux.vnet.ibm.com, linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 5.17 23/43] scsi: lpfc: Allow reduced polling rate for nvme_admin_async_event cmd completion
Date: Mon, 13 Jun 2022 22:05:42 -0400 [thread overview]
Message-ID: <20220614020602.1098943-23-sashal@kernel.org> (raw)
In-Reply-To: <20220614020602.1098943-1-sashal@kernel.org>
From: James Smart <jsmart2021@gmail.com>
[ Upstream commit 2e7e9c0c1ec05f18d320ecc8a31eec59d2af1af9 ]
NVMe Asynchronous Event Request commands have no command timeout value per
specifications.
Set WQE option to allow a reduced FLUSH polling rate for I/O error
detection specifically for nvme_admin_async_event commands.
Link: https://lore.kernel.org/r/20220603174329.63777-9-jsmart2021@gmail.com
Co-developed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/scsi/lpfc/lpfc_hw4.h | 3 +++
drivers/scsi/lpfc/lpfc_nvme.c | 11 +++++++++--
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h
index 6ec42991d2ab..f7095888b715 100644
--- a/drivers/scsi/lpfc/lpfc_hw4.h
+++ b/drivers/scsi/lpfc/lpfc_hw4.h
@@ -4452,6 +4452,9 @@ struct wqe_common {
#define wqe_sup_SHIFT 6
#define wqe_sup_MASK 0x00000001
#define wqe_sup_WORD word11
+#define wqe_ffrq_SHIFT 6
+#define wqe_ffrq_MASK 0x00000001
+#define wqe_ffrq_WORD word11
#define wqe_wqec_SHIFT 7
#define wqe_wqec_MASK 0x00000001
#define wqe_wqec_WORD word11
diff --git a/drivers/scsi/lpfc/lpfc_nvme.c b/drivers/scsi/lpfc/lpfc_nvme.c
index df73abb59407..b981c3a2b366 100644
--- a/drivers/scsi/lpfc/lpfc_nvme.c
+++ b/drivers/scsi/lpfc/lpfc_nvme.c
@@ -1193,7 +1193,8 @@ lpfc_nvme_prep_io_cmd(struct lpfc_vport *vport,
{
struct lpfc_hba *phba = vport->phba;
struct nvmefc_fcp_req *nCmd = lpfc_ncmd->nvmeCmd;
- struct lpfc_iocbq *pwqeq = &(lpfc_ncmd->cur_iocbq);
+ struct nvme_common_command *sqe;
+ struct lpfc_iocbq *pwqeq = &lpfc_ncmd->cur_iocbq;
union lpfc_wqe128 *wqe = &pwqeq->wqe;
uint32_t req_len;
@@ -1250,8 +1251,14 @@ lpfc_nvme_prep_io_cmd(struct lpfc_vport *vport,
cstat->control_requests++;
}
- if (pnode->nlp_nvme_info & NLP_NVME_NSLER)
+ if (pnode->nlp_nvme_info & NLP_NVME_NSLER) {
bf_set(wqe_erp, &wqe->generic.wqe_com, 1);
+ sqe = &((struct nvme_fc_cmd_iu *)
+ nCmd->cmdaddr)->sqe.common;
+ if (sqe->opcode == nvme_admin_async_event)
+ bf_set(wqe_ffrq, &wqe->generic.wqe_com, 1);
+ }
+
/*
* Finish initializing those WQE fields that are independent
* of the nvme_cmnd request_buffer
--
2.35.1
next prev parent reply other threads:[~2022-06-14 2:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:05 [PATCH AUTOSEL 5.17 01/43] powerpc/kasan: Silence KASAN warnings in __get_wchan() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 02/43] ASoC: nau8822: Add operation for internal PLL off and on Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 03/43] drm/amd/display: Read Golden Settings Table from VBIOS Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 04/43] drm/amd/display: Fix DMUB outbox trace in S4 (#4465) Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 05/43] drm/amdkfd: Use mmget_not_zero in MMU notifier Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 06/43] dma-debug: make things less spammy under memory pressure Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 07/43] ASoC: cs42l52: Fix TLV scales for mixer controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 08/43] ASoC: cs35l36: Update digital volume TLV Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 09/43] ASoC: cs53l30: Correct number of volume levels on SX controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 10/43] ASoC: cs42l52: Correct TLV for Bypass Volume Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 11/43] ASoC: cs42l56: Correct typo in minimum level for SX volume controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 12/43] ASoC: cs42l51: Correct minimum value for SX volume control Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 13/43] drm/amdkfd: add pinned BOs to kfd_bo_list Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 14/43] ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 15/43] quota: Prevent memory allocation recursion while holding dq_lock Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 16/43] ASoC: wm8962: Fix suspend while playing music Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 17/43] ASoC: es8328: Fix event generation for deemphasis control Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 18/43] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 19/43] Input: soc_button_array - also add Lenovo Yoga Tablet2 1051F to dmi_use_low_level_irq Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 20/43] scsi: vmw_pvscsi: Expand vcpuHint to 16 bits Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 21/43] scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO is aborted Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 22/43] scsi: lpfc: Fix port stuck in bypassed state after LIP in PT2PT topology Sasha Levin
2022-06-14 2:05 ` Sasha Levin [this message]
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 24/43] scsi: mpt3sas: Fix out-of-bounds compiler warning Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 25/43] scsi: ipr: Fix missing/incorrect resource cleanup in error case Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 26/43] scsi: pmcraid: Fix missing " Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 27/43] ALSA: hda/realtek - Add HW8326 support Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 28/43] virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 29/43] nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 30/43] ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 31/43] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 32/43] gcc-12: disable '-Wdangling-pointer' warning for now Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 33/43] mellanox: mlx5: avoid uninitialized variable warning with gcc-12 Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 34/43] gcc-12: disable '-Warray-bounds' universally for now Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 35/43] netfs: gcc-12: temporarily disable '-Wattribute-warning' " Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 36/43] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 37/43] random: credit cpu and bootloader seeds by default Sasha Levin
2022-06-14 8:51 ` Jason A. Donenfeld
2022-06-14 12:46 ` Jason A. Donenfeld
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 38/43] gpio: dwapb: Don't print error on -EPROBE_DEFER Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 39/43] platform/x86/intel: Fix pmt_crashlog array reference Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 40/43] platform/x86/intel: pmc: Support Intel Raptorlake P Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 41/43] platform/x86: gigabyte-wmi: Add Z690M AORUS ELITE AX DDR4 support Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 42/43] platform/x86: gigabyte-wmi: Add support for B450M DS3H-CF Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 43/43] platform/x86/intel: hid: Add Surface Go to VGBS allow list Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614020602.1098943-23-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=dick.kennedy@avagotech.com \
--cc=james.smart@avagotech.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jsmart2021@gmail.com \
--cc=justin.tee@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®