From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: David Arcari <darcari@redhat.com>,
"David E. Box" <david.e.box@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Sasha Levin <sashal@kernel.org>,
dvhart@infradead.org, platform-driver-x86@vger.kernel.org
Subject: [PATCH AUTOSEL 5.17 39/43] platform/x86/intel: Fix pmt_crashlog array reference
Date: Mon, 13 Jun 2022 22:05:58 -0400 [thread overview]
Message-ID: <20220614020602.1098943-39-sashal@kernel.org> (raw)
In-Reply-To: <20220614020602.1098943-1-sashal@kernel.org>
From: David Arcari <darcari@redhat.com>
[ Upstream commit 66cb3a2d7ad0d0e9af4d3430a4f2a32ffb9ac098 ]
The probe function pmt_crashlog_probe() may incorrectly reference
the 'priv->entry array' as it uses 'i' to reference the array instead
of 'priv->num_entries' as it should. This is similar to the problem
that was addressed in pmt_telemetry_probe via commit 2cdfa0c20d58
("platform/x86/intel: Fix 'rmmod pmt_telemetry' panic").
Cc: "David E. Box" <david.e.box@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: David Arcari <darcari@redhat.com>
Reviewed-by: David E. Box <david.e.box@linux.intel.com>
Link: https://lore.kernel.org/r/20220526203140.339120-1-darcari@redhat.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
drivers/platform/x86/intel/pmt/crashlog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel/pmt/crashlog.c b/drivers/platform/x86/intel/pmt/crashlog.c
index 34daf9df168b..ace1239bc0a0 100644
--- a/drivers/platform/x86/intel/pmt/crashlog.c
+++ b/drivers/platform/x86/intel/pmt/crashlog.c
@@ -282,7 +282,7 @@ static int pmt_crashlog_probe(struct auxiliary_device *auxdev,
auxiliary_set_drvdata(auxdev, priv);
for (i = 0; i < intel_vsec_dev->num_resources; i++) {
- struct intel_pmt_entry *entry = &priv->entry[i].entry;
+ struct intel_pmt_entry *entry = &priv->entry[priv->num_entries].entry;
ret = intel_pmt_dev_create(entry, &pmt_crashlog_ns, intel_vsec_dev, i);
if (ret < 0)
--
2.35.1
next prev parent reply other threads:[~2022-06-14 2:13 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 2:05 [PATCH AUTOSEL 5.17 01/43] powerpc/kasan: Silence KASAN warnings in __get_wchan() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 02/43] ASoC: nau8822: Add operation for internal PLL off and on Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 03/43] drm/amd/display: Read Golden Settings Table from VBIOS Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 04/43] drm/amd/display: Fix DMUB outbox trace in S4 (#4465) Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 05/43] drm/amdkfd: Use mmget_not_zero in MMU notifier Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 06/43] dma-debug: make things less spammy under memory pressure Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 07/43] ASoC: cs42l52: Fix TLV scales for mixer controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 08/43] ASoC: cs35l36: Update digital volume TLV Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 09/43] ASoC: cs53l30: Correct number of volume levels on SX controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 10/43] ASoC: cs42l52: Correct TLV for Bypass Volume Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 11/43] ASoC: cs42l56: Correct typo in minimum level for SX volume controls Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 12/43] ASoC: cs42l51: Correct minimum value for SX volume control Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 13/43] drm/amdkfd: add pinned BOs to kfd_bo_list Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 14/43] ata: libata-core: fix NULL pointer deref in ata_host_alloc_pinfo() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 15/43] quota: Prevent memory allocation recursion while holding dq_lock Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 16/43] ASoC: wm8962: Fix suspend while playing music Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 17/43] ASoC: es8328: Fix event generation for deemphasis control Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 18/43] ASoC: wm_adsp: Fix event generation for wm_adsp_fw_put() Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 19/43] Input: soc_button_array - also add Lenovo Yoga Tablet2 1051F to dmi_use_low_level_irq Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 20/43] scsi: vmw_pvscsi: Expand vcpuHint to 16 bits Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 21/43] scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO is aborted Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 22/43] scsi: lpfc: Fix port stuck in bypassed state after LIP in PT2PT topology Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 23/43] scsi: lpfc: Allow reduced polling rate for nvme_admin_async_event cmd completion Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 24/43] scsi: mpt3sas: Fix out-of-bounds compiler warning Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 25/43] scsi: ipr: Fix missing/incorrect resource cleanup in error case Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 26/43] scsi: pmcraid: Fix missing " Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 27/43] ALSA: hda/realtek - Add HW8326 support Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 28/43] virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 29/43] nfc: nfcmrvl: Fix memory leak in nfcmrvl_play_deferred Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 30/43] ipv6: Fix signed integer overflow in l2tp_ip6_sendmsg Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 31/43] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 32/43] gcc-12: disable '-Wdangling-pointer' warning for now Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 33/43] mellanox: mlx5: avoid uninitialized variable warning with gcc-12 Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 34/43] gcc-12: disable '-Warray-bounds' universally for now Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 35/43] netfs: gcc-12: temporarily disable '-Wattribute-warning' " Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 36/43] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error Sasha Levin
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 37/43] random: credit cpu and bootloader seeds by default Sasha Levin
2022-06-14 8:51 ` Jason A. Donenfeld
2022-06-14 12:46 ` Jason A. Donenfeld
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 38/43] gpio: dwapb: Don't print error on -EPROBE_DEFER Sasha Levin
2022-06-14 2:05 ` Sasha Levin [this message]
2022-06-14 2:05 ` [PATCH AUTOSEL 5.17 40/43] platform/x86/intel: pmc: Support Intel Raptorlake P Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 41/43] platform/x86: gigabyte-wmi: Add Z690M AORUS ELITE AX DDR4 support Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 42/43] platform/x86: gigabyte-wmi: Add support for B450M DS3H-CF Sasha Levin
2022-06-14 2:06 ` [PATCH AUTOSEL 5.17 43/43] platform/x86/intel: hid: Add Surface Go to VGBS allow list Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614020602.1098943-39-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=darcari@redhat.com \
--cc=david.e.box@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®