* [PATCH] drm: logicvc: Add missing of_node_put() in logicvc_drm_config_parse()
@ 2022-06-14 6:24 Peng Wu
0 siblings, 0 replies; only message in thread
From: Peng Wu @ 2022-06-14 6:24 UTC (permalink / raw)
To: airlied, daniel; +Cc: dri-devel, linux-kernel, liwei391, wupeng58
of_get_child_by_name() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
---
drivers/gpu/drm/logicvc/logicvc_drm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c
index df1805cf0f95..73d51a8b693e 100644
--- a/drivers/gpu/drm/logicvc/logicvc_drm.c
+++ b/drivers/gpu/drm/logicvc/logicvc_drm.c
@@ -136,8 +136,10 @@ static int logicvc_drm_config_parse(struct logicvc_drm *logicvc)
if (!config->layers_count) {
drm_err(drm_dev,
"Missing a non-optional layers children node\n");
+ of_node_put(layers_node);
return -EINVAL;
}
+ of_node_put(layers_node);
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-14 6:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 6:24 [PATCH] drm: logicvc: Add missing of_node_put() in logicvc_drm_config_parse() Peng Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®