From: Andrew Jones <drjones@redhat.com>
To: shaoqin.huang@intel.com
Cc: pbonzini@redhat.com, Shuah Khan <shuah@kernel.org>,
Sean Christopherson <seanjc@google.com>,
David Matlack <dmatlack@google.com>,
Marc Zyngier <maz@kernel.org>, Oliver Upton <oupton@google.com>,
Ricardo Koller <ricarkol@google.com>,
Wei Wang <wei.w.wang@intel.com>, Peter Gonda <pgonda@google.com>,
David Dunn <daviddunn@google.com>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
Date: Tue, 14 Jun 2022 09:48:35 +0200 [thread overview]
Message-ID: <20220614074835.qto55feu74ionlh5@gator> (raw)
In-Reply-To: <20220614224126.211054-1-shaoqin.huang@intel.com>
On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote:
> From: Shaoqin Huang <shaoqin.huang@intel.com>
>
> There are some parameter being removed in function but the parameter
> comments still exist, so remove them.
>
> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
> ---
> tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> index 1665a220abcb..58fdc82b20f4 100644
> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
> * vm - Virtual Machine
> * sz - Size in bytes
> * vaddr_min - Minimum starting virtual address
> - * data_memslot - Memory region slot for data pages
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
> * vaddr - Virtuall address to map
> * paddr - VM Physical Address
> * npages - The number of pages to map
> - * pgd_memslot - Memory region slot for new virtual translation tables
> *
> * Output Args: None
> *
> --
> 2.30.2
>
Hi Shaoqin,
Please check kvm/queue, the extra parameter comments have already been
removed.
Thanks,
drew
next prev parent reply other threads:[~2022-06-14 7:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 22:41 shaoqin.huang
2022-06-14 7:48 ` Andrew Jones [this message]
2022-06-14 8:28 ` Andrew Jones
2022-06-14 8:57 ` Huang, Shaoqin
2022-06-14 17:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220614074835.qto55feu74ionlh5@gator \
--to=drjones@redhat.com \
--cc=daviddunn@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@google.com \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=ricarkol@google.com \
--cc=seanjc@google.com \
--cc=shaoqin.huang@intel.com \
--cc=shuah@kernel.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®