* [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list.
@ 2022-06-15 10:45 Eugene Shalygin
2022-06-15 10:46 ` Eugene Shalygin
2022-06-15 11:57 ` Guenter Roeck
0 siblings, 2 replies; 4+ messages in thread
From: Eugene Shalygin @ 2022-06-15 10:45 UTC (permalink / raw)
To: eugene.shalygin
Cc: Michael Carns, Jean Delvare, Guenter Roeck, linux-hwmon, linux-kernel
From: Michael Carns <mike@carns.com>
This fixes a regression introduced by commit 5b4285c57b6f
("hwmon: (asus-ec-sensors) fix Formula VIII definition")
where coma lead to concatenating board names and broke module
loading for C8H.
Signed-off-by: Michael Carns <mike@carns.com>
Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
---
drivers/hwmon/asus-ec-sensors.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
index 886a71b4c64e..19d3ca71b360 100644
--- a/drivers/hwmon/asus-ec-sensors.c
+++ b/drivers/hwmon/asus-ec-sensors.c
@@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
},
{
.board_names = {
- "ROG CROSSHAIR VIII FORMULA"
+ "ROG CROSSHAIR VIII FORMULA",
"ROG CROSSHAIR VIII HERO",
"ROG CROSSHAIR VIII HERO (WI-FI)",
},
--
2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list.
2022-06-15 10:45 [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list Eugene Shalygin
@ 2022-06-15 10:46 ` Eugene Shalygin
2022-06-15 11:57 ` Guenter Roeck
1 sibling, 0 replies; 4+ messages in thread
From: Eugene Shalygin @ 2022-06-15 10:46 UTC (permalink / raw)
To: Eugene Shalygin
Cc: Michael Carns, Jean Delvare, Guenter Roeck, linux-hwmon,
Linux Kernel Mailing List
The error already made it into 5.19-rc1, unfortunately...
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list.
2022-06-15 10:45 [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list Eugene Shalygin
2022-06-15 10:46 ` Eugene Shalygin
@ 2022-06-15 11:57 ` Guenter Roeck
2022-06-15 12:27 ` Eugene Shalygin
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2022-06-15 11:57 UTC (permalink / raw)
To: Eugene Shalygin; +Cc: Michael Carns, Jean Delvare, linux-hwmon, linux-kernel
On 6/15/22 03:45, Eugene Shalygin wrote:
> From: Michael Carns <mike@carns.com>
>
> This fixes a regression introduced by commit 5b4285c57b6f
> ("hwmon: (asus-ec-sensors) fix Formula VIII definition")
> where coma lead to concatenating board names and broke module
> loading for C8H.
>
> Signed-off-by: Michael Carns <mike@carns.com>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
We have a Fixes: tag for such purposes. Please use it.
Thanks,
Guenter
> ---
> drivers/hwmon/asus-ec-sensors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 886a71b4c64e..19d3ca71b360 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -268,7 +268,7 @@ static const struct ec_board_info board_info[] = {
> },
> {
> .board_names = {
> - "ROG CROSSHAIR VIII FORMULA"
> + "ROG CROSSHAIR VIII FORMULA",
> "ROG CROSSHAIR VIII HERO",
> "ROG CROSSHAIR VIII HERO (WI-FI)",
> },
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-15 12:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 10:45 [PATCH] hwmon: (asus-ec-sensors) add missing comma in board name list Eugene Shalygin
2022-06-15 10:46 ` Eugene Shalygin
2022-06-15 11:57 ` Guenter Roeck
2022-06-15 12:27 ` Eugene Shalygin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®