* [PATCH] arch: microblaze: pci: Add missing of_node_put() in xilinx_pci.c
@ 2022-06-15 13:03 Liang He
0 siblings, 0 replies; only message in thread
From: Liang He @ 2022-06-15 13:03 UTC (permalink / raw)
To: monstr, wangxiang; +Cc: linux-arm-kernel, linux-kernel, windhl
In xilinx_pci_init(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put() in
fail path or when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/microblaze/pci/xilinx_pci.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/microblaze/pci/xilinx_pci.c b/arch/microblaze/pci/xilinx_pci.c
index f4cb86fffcee..018d91bdcbb9 100644
--- a/arch/microblaze/pci/xilinx_pci.c
+++ b/arch/microblaze/pci/xilinx_pci.c
@@ -132,13 +132,13 @@ void __init xilinx_pci_init(void)
if (of_address_to_resource(pci_node, 0, &r)) {
pr_err("xilinx-pci: cannot resolve base address\n");
- return;
+ goto out_put;
}
hose = pcibios_alloc_controller(pci_node);
if (!hose) {
pr_err("xilinx-pci: pcibios_alloc_controller() failed\n");
- return;
+ goto out_put;
}
/* Setup config space */
@@ -167,4 +167,7 @@ void __init xilinx_pci_init(void)
pr_info("xilinx-pci: Registered PCI host bridge\n");
xilinx_early_pci_scan(hose);
+
+out_put:
+ of_node_put(pci_node);
}
--
2.25.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-15 13:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 13:03 [PATCH] arch: microblaze: pci: Add missing of_node_put() in xilinx_pci.c Liang He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®