* [PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put()
@ 2022-06-16 3:53 Liang He
2023-09-13 12:15 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-16 3:53 UTC (permalink / raw)
To: linus.walleij, linux; +Cc: linux-arm-kernel, linux-kernel, windhl
In realview_smp_prepare_cpus(), the second of_find_matching_node()
has no corresponding of_node_put() when the node pointer is not
used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
changelog:
v2: use real name for Sob
v1: fix missing bug
arch/arm/mach-versatile/platsmp-realview.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-versatile/platsmp-realview.c b/arch/arm/mach-versatile/platsmp-realview.c
index 5d363385c801..059d796b26bc 100644
--- a/arch/arm/mach-versatile/platsmp-realview.c
+++ b/arch/arm/mach-versatile/platsmp-realview.c
@@ -66,6 +66,7 @@ static void __init realview_smp_prepare_cpus(unsigned int max_cpus)
return;
}
map = syscon_node_to_regmap(np);
+ of_node_put(np);
if (IS_ERR(map)) {
pr_err("PLATSMP: No syscon regmap\n");
return;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put()
2022-06-16 3:53 [PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put() Liang He
@ 2023-09-13 12:15 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-09-13 12:15 UTC (permalink / raw)
To: Liang He; +Cc: linux, linux-arm-kernel, linux-kernel
On Thu, Jun 16, 2022 at 5:54 AM Liang He <windhl@126.com> wrote:
> In realview_smp_prepare_cpus(), the second of_find_matching_node()
> has no corresponding of_node_put() when the node pointer is not
> used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-13 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-16 3:53 [PATCH v2] mach-versatile: (platsmp-realview) Add missing of_node_put() Liang He
2023-09-13 12:15 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®