* [PATCH] usb: host: ohci-ppc-of: Fix refcount leak bug
@ 2022-06-17 3:46 Liang He
2022-06-17 15:15 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-17 3:46 UTC (permalink / raw)
To: stern, gregkh; +Cc: windhl, linux-usb, linux-kernel
In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return
a node pointer with refcount incremented. We should use of_node_put()
when it is not used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
drivers/usb/host/ohci-ppc-of.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c
index 1960b8dfdba5..591f675cc930 100644
--- a/drivers/usb/host/ohci-ppc-of.c
+++ b/drivers/usb/host/ohci-ppc-of.c
@@ -166,6 +166,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op)
release_mem_region(res.start, 0x4);
} else
pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__);
+ of_node_put(np);
}
irq_dispose_mapping(irq);
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] usb: host: ohci-ppc-of: Fix refcount leak bug
2022-06-17 3:46 [PATCH] usb: host: ohci-ppc-of: Fix refcount leak bug Liang He
@ 2022-06-17 15:15 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2022-06-17 15:15 UTC (permalink / raw)
To: Liang He; +Cc: gregkh, linux-usb, linux-kernel
On Fri, Jun 17, 2022 at 11:46:37AM +0800, Liang He wrote:
> In ohci_hcd_ppc_of_probe(), of_find_compatible_node() will return
> a node pointer with refcount incremented. We should use of_node_put()
> when it is not used anymore.
>
> Signed-off-by: Liang He <windhl@126.com>
> ---
Acked-by: Alan Stern <stern@rowland.harvard.edu>
This seems to be the last one; ehci-ppc-of.c was already fixed by an
earlier patch.
> drivers/usb/host/ohci-ppc-of.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/ohci-ppc-of.c b/drivers/usb/host/ohci-ppc-of.c
> index 1960b8dfdba5..591f675cc930 100644
> --- a/drivers/usb/host/ohci-ppc-of.c
> +++ b/drivers/usb/host/ohci-ppc-of.c
> @@ -166,6 +166,7 @@ static int ohci_hcd_ppc_of_probe(struct platform_device *op)
> release_mem_region(res.start, 0x4);
> } else
> pr_debug("%s: cannot get ehci offset from fdt\n", __FILE__);
> + of_node_put(np);
> }
>
> irq_dispose_mapping(irq);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-17 15:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 3:46 [PATCH] usb: host: ohci-ppc-of: Fix refcount leak bug Liang He
2022-06-17 15:15 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®