mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sh: sh2: Fix refcount leak bug in smp-j2
@ 2022-06-17 12:00 Liang He
  0 siblings, 0 replies; only message in thread
From: Liang He @ 2022-06-17 12:00 UTC (permalink / raw)
  To: ysato, dalias; +Cc: windhl, linux-sh, linux-kernel

In j2_prepare_cpus(), of_find_compatible_node() will return a
node pointer with refcount incremented. We should use of_node_put()
in fail path or when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
---
 arch/sh/kernel/cpu/sh2/smp-j2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/sh/kernel/cpu/sh2/smp-j2.c b/arch/sh/kernel/cpu/sh2/smp-j2.c
index d0d5d81455ae..995fb5da6ff3 100644
--- a/arch/sh/kernel/cpu/sh2/smp-j2.c
+++ b/arch/sh/kernel/cpu/sh2/smp-j2.c
@@ -51,6 +51,7 @@ static void j2_prepare_cpus(unsigned int max_cpus)
 
 	j2_ipi_irq = irq_of_parse_and_map(np, 0);
 	j2_ipi_trigger = of_iomap(np, 0);
+	of_node_put(np);
 	if (!j2_ipi_irq || !j2_ipi_trigger)
 		goto out;
 
@@ -59,6 +60,7 @@ static void j2_prepare_cpus(unsigned int max_cpus)
 		goto out;
 
 	sh2_cpuid_addr = of_iomap(np, 0);
+	of_node_put(np);
 	if (!sh2_cpuid_addr)
 		goto out;
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-06-17 12:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 12:00 [PATCH] sh: sh2: Fix refcount leak bug in smp-j2 Liang He

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®