* [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup
@ 2022-06-18 2:49 Liang He
2022-09-09 12:07 ` Michael Ellerman
0 siblings, 1 reply; 2+ messages in thread
From: Liang He @ 2022-06-18 2:49 UTC (permalink / raw)
To: christophe.leroy, mpe, benh, paulus; +Cc: windhl, linuxppc-dev, linux-kernel
In init_ioports(), of_find_node_by_name() will return a node pointer
with refcount incremented. We should use of_node_put() when it is not
used anymore.
Signed-off-by: Liang He <windhl@126.com>
---
arch/powerpc/platforms/8xx/tqm8xx_setup.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/powerpc/platforms/8xx/tqm8xx_setup.c b/arch/powerpc/platforms/8xx/tqm8xx_setup.c
index 3725d51248df..ffcfd17a5fa3 100644
--- a/arch/powerpc/platforms/8xx/tqm8xx_setup.c
+++ b/arch/powerpc/platforms/8xx/tqm8xx_setup.c
@@ -105,6 +105,9 @@ static void __init init_ioports(void)
if (dnode == NULL)
return;
prop = of_find_property(dnode, "ethernet1", &len);
+
+ of_node_put(dnode);
+
if (prop == NULL)
return;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup
2022-06-18 2:49 [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup Liang He
@ 2022-09-09 12:07 ` Michael Ellerman
0 siblings, 0 replies; 2+ messages in thread
From: Michael Ellerman @ 2022-09-09 12:07 UTC (permalink / raw)
To: paulus, Liang He, christophe.leroy, benh, mpe; +Cc: linuxppc-dev, linux-kernel
On Sat, 18 Jun 2022 10:49:30 +0800, Liang He wrote:
> In init_ioports(), of_find_node_by_name() will return a node pointer
> with refcount incremented. We should use of_node_put() when it is not
> used anymore.
>
>
Applied to powerpc/next.
[1/1] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup
https://git.kernel.org/powerpc/c/edc17890ae8ee475b566079bea2e9ba83fec021d
cheers
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-09 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-18 2:49 [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup Liang He
2022-09-09 12:07 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®