* [PATCH v2 0/2] Skip IRQ1 override for two laptops
@ 2022-06-19 13:16 Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 1/2] ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 2/2] ACPI: skip IRQ1 override on Redmi Book Pro 15 2022 Chuanhong Guo
0 siblings, 2 replies; 3+ messages in thread
From: Chuanhong Guo @ 2022-06-19 13:16 UTC (permalink / raw)
To: linux-acpi; +Cc: Chuanhong Guo, Rafael J. Wysocki, Len Brown, open list
The IRQ1 of these two laptops with Ryzen 6000 and Insyde UEFI
are active low, as described in ACPI DSDT. The kernel override
made their keyboard non-functional.
This patchset skips override for them.
Changes since v1:
Match DMI DMI_PRODUCT_NAME for ThinkBook because the board name
is used for other completely different Lenovo laptops.
Add a patch for RedmiBook
Chuanhong Guo (1):
ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA
Tighe Donnelly (1):
ACPI: skip IRQ1 override on Redmi Book Pro 15 2022
drivers/acpi/resource.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA
2022-06-19 13:16 [PATCH v2 0/2] Skip IRQ1 override for two laptops Chuanhong Guo
@ 2022-06-19 13:16 ` Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 2/2] ACPI: skip IRQ1 override on Redmi Book Pro 15 2022 Chuanhong Guo
1 sibling, 0 replies; 3+ messages in thread
From: Chuanhong Guo @ 2022-06-19 13:16 UTC (permalink / raw)
To: linux-acpi; +Cc: Chuanhong Guo, stable, Rafael J. Wysocki, Len Brown, open list
The IRQ is described as (Edge, ActiveLow, Shared, ) in ACPI DSDT and
it's correct. The override makes the keyboard interrupt polarity
inverted, resulting in non-functional keyboard.
Add an entry for skipping the override.
Cc: <stable@vger.kernel.org>
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
Change since v1:
Match DMI DMI_PRODUCT_NAME for ThinkBook because the board name
is used for other completely different Lenovo laptops.
drivers/acpi/resource.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index c2d494784425..b69c229b23dd 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -399,6 +399,17 @@ static const struct dmi_system_id medion_laptop[] = {
{ }
};
+static const struct dmi_system_id irq1_edge_low_shared[] = {
+ {
+ .ident = "Lenovo ThinkBook 14 G4+ ARA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
+ },
+ },
+ { }
+};
+
struct irq_override_cmp {
const struct dmi_system_id *system;
unsigned char irq;
@@ -409,6 +420,7 @@ struct irq_override_cmp {
static const struct irq_override_cmp skip_override_table[] = {
{ medion_laptop, 1, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW, 0 },
+ { irq1_edge_low_shared, 1, ACPI_EDGE_SENSITIVE, ACPI_ACTIVE_LOW, 1 },
};
static bool acpi_dev_irq_override(u32 gsi, u8 triggering, u8 polarity,
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] ACPI: skip IRQ1 override on Redmi Book Pro 15 2022
2022-06-19 13:16 [PATCH v2 0/2] Skip IRQ1 override for two laptops Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 1/2] ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA Chuanhong Guo
@ 2022-06-19 13:16 ` Chuanhong Guo
1 sibling, 0 replies; 3+ messages in thread
From: Chuanhong Guo @ 2022-06-19 13:16 UTC (permalink / raw)
To: linux-acpi
Cc: Chuanhong Guo, stable, Tighe Donnelly, Rafael J. Wysocki,
Len Brown, open list
From: Tighe Donnelly <tighe.donnelly@protonmail.com>
The IRQ is described as (Edge, ActiveLow, Shared, ) in ACPI DSDT and
it's correct. The override makes the keyboard interrupt polarity
inverted, resulting in non-functional keyboard.
Add an entry for skipping the override.
Cc: <stable@vger.kernel.org>
Signed-off-by: Tighe Donnelly <tighe.donnelly@protonmail.com>
Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---
Change since v1: new patch
drivers/acpi/resource.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index b69c229b23dd..d9d8d546f340 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -407,6 +407,13 @@ static const struct dmi_system_id irq1_edge_low_shared[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "21D0"),
},
},
+ {
+ .ident = "Redmi Book Pro 15 2022",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TIMI"),
+ DMI_MATCH(DMI_BOARD_NAME, "TM2113"),
+ },
+ },
{ }
};
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-19 13:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-19 13:16 [PATCH v2 0/2] Skip IRQ1 override for two laptops Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 1/2] ACPI: skip IRQ1 override on Lenovo ThinkBook 14G4+ ARA Chuanhong Guo
2022-06-19 13:16 ` [PATCH v2 2/2] ACPI: skip IRQ1 override on Redmi Book Pro 15 2022 Chuanhong Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®