* [PATCH] soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()
@ 2022-06-21 11:46 Peng Wu
2022-06-22 14:02 ` Matthias Brugger
0 siblings, 1 reply; 3+ messages in thread
From: Peng Wu @ 2022-06-21 11:46 UTC (permalink / raw)
To: matthias.bgg
Cc: linux-arm-kernel, linux-mediatek, linux-kernel, liwei391, wupeng58
Fix the missing clk_disable_unprepare() before return
from svs_resume() in the error handling case.
Signed-off-by: Peng Wu <wupeng58@huawei.com>
Reported-by: Hulk Robot <hulkci@huawei.com>
---
drivers/soc/mediatek/mtk-svs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 606a00a2e57d..1b5c297aaec5 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1525,6 +1525,7 @@ static int svs_resume(struct device *dev)
ret = reset_control_deassert(svsp->rst);
if (ret) {
+ clk_disable_unprepare(svsp->main_clk);
dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
return ret;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()
2022-06-21 11:46 [PATCH] soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume() Peng Wu
@ 2022-06-22 14:02 ` Matthias Brugger
2022-06-23 6:50 ` wupeng (D)
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Brugger @ 2022-06-22 14:02 UTC (permalink / raw)
To: Peng Wu; +Cc: linux-arm-kernel, linux-mediatek, linux-kernel, liwei391
On 21/06/2022 13:46, Peng Wu wrote:
> Fix the missing clk_disable_unprepare() before return
> from svs_resume() in the error handling case.
>
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> ---
> drivers/soc/mediatek/mtk-svs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
> index 606a00a2e57d..1b5c297aaec5 100644
> --- a/drivers/soc/mediatek/mtk-svs.c
> +++ b/drivers/soc/mediatek/mtk-svs.c
> @@ -1525,6 +1525,7 @@ static int svs_resume(struct device *dev)
>
> ret = reset_control_deassert(svsp->rst);
> if (ret) {
> + clk_disable_unprepare(svsp->main_clk);
Same holds for the error path of svs_init02(), correct?
Regards,
Matthias
> dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
> return ret;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume()
2022-06-22 14:02 ` Matthias Brugger
@ 2022-06-23 6:50 ` wupeng (D)
0 siblings, 0 replies; 3+ messages in thread
From: wupeng (D) @ 2022-06-23 6:50 UTC (permalink / raw)
To: Matthias Brugger; +Cc: linux-arm-kernel, linux-mediatek, linux-kernel, liwei391
On 2022/6/22 22:02, Matthias Brugger wrote:
>
>
> On 21/06/2022 13:46, Peng Wu wrote:
>> Fix the missing clk_disable_unprepare() before return
>> from svs_resume() in the error handling case.
>>
>> Signed-off-by: Peng Wu <wupeng58@huawei.com>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> ---
>> drivers/soc/mediatek/mtk-svs.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>> index 606a00a2e57d..1b5c297aaec5 100644
>> --- a/drivers/soc/mediatek/mtk-svs.c
>> +++ b/drivers/soc/mediatek/mtk-svs.c
>> @@ -1525,6 +1525,7 @@ static int svs_resume(struct device *dev)
>> ret = reset_control_deassert(svsp->rst);
>> if (ret) {
>> + clk_disable_unprepare(svsp->main_clk);
>
> Same holds for the error path of svs_init02(), correct?
>
> Regards,
> Matthias
>
>> dev_err(svsp->dev, "cannot deassert reset %d\n", ret);
>> return ret;
>> }
> .
Yes, the error path of svs_init02() requires the same operation.
I will resubmit a patch.
Regards,
Peng
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-23 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 11:46 [PATCH] soc: mediatek: fix missing clk_disable_unprepare() on err in svs_resume() Peng Wu
2022-06-22 14:02 ` Matthias Brugger
2022-06-23 6:50 ` wupeng (D)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®