mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
To: <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>
Cc: <joro@8bytes.org>, <robin.murphy@arm.com>, <ashish.kalra@amd.com>,
	<vasant.hegde@amd.com>, <thomas.lendacky@amd.com>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Subject: [PATCH v3 0/7] iommu/amd: Enforce IOMMU restrictions for SNP-enabled system
Date: Wed, 22 Jun 2022 12:11:24 -0500	[thread overview]
Message-ID: <20220622171131.11870-1-suravee.suthikulpanit@amd.com> (raw)

SNP-enabled system requires IOMMU v1 page table to be configured with
non-zero DTE[Mode] for DMA-capable devices. This effects a number of
usecases such as IOMMU pass-through mode and AMD IOMMUv2 APIs for
binding/unbinding pasid.

The series introduce a global variable to check SNP-enabled state
during driver initialization, and use it to enforce the SNP restrictions
during runtime.

Also, for non-DMA-capable devices such as IOAPIC, the recommendation
is to set DTE[TV] and DTE[Mode] to zero on SNP-enabled system.
Therefore, additinal checks is added before setting DTE[TV].

Testing:
  - Tested booting and verify dmesg.
  - Tested booting with iommu=pt
  - Tested loading amd_iommu_v2 driver
  - Tested changing the iommu domain at runtime
  - Tested booting SEV/SNP-enabled guest
  - Tested when CONFIG_AMD_MEM_ENCRYPT is not set

Pre-requisite:
  - [PATCH v3 00/35] iommu/amd: Add multiple PCI segments support
    https://lore.kernel.org/linux-iommu/20220511072141.15485-29-vasant.hegde@amd.com/T/

Chanages from V2:
(https://lists.linuxfoundation.org/pipermail/iommu/2022-June/066392.html)
  - Patch 4:
     * Update pr_err message to report SNP not supported.
     * Remove export GPL.
     * Remove function stub when CONFIG_AMD_MEM_ENCRYPT is not set.
  - Patch 6: Change to WARN_ONCE.

Best Regards,
Suravee

Brijesh Singh (1):
  iommu/amd: Introduce function to check and enable SNP

Suravee Suthikulpanit (6):
  iommu/amd: Warn when found inconsistency EFR mask
  iommu/amd: Process all IVHDs before enabling IOMMU features
  iommu/amd: Introduce an iommu variable for tracking SNP support status
  iommu/amd: Set translation valid bit only when IO page tables are in
    use
  iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled
  iommu/amd: Do not support IOMMUv2 APIs when SNP is enabled

 drivers/iommu/amd/amd_iommu_types.h |   5 ++
 drivers/iommu/amd/init.c            | 109 +++++++++++++++++++++++-----
 drivers/iommu/amd/iommu.c           |  27 ++++++-
 include/linux/amd-iommu.h           |   4 +
 4 files changed, 123 insertions(+), 22 deletions(-)

-- 
2.32.0


             reply	other threads:[~2022-06-22 17:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 17:11 Suravee Suthikulpanit [this message]
2022-06-22 17:11 ` [PATCH v3 1/7] iommu/amd: Warn when found inconsistency EFR mask Suravee Suthikulpanit
2022-06-23  8:22   ` Joerg Roedel
2022-06-29 11:50     ` Suthikulpanit, Suravee
2022-06-22 17:11 ` [PATCH v3 2/7] iommu/amd: Process all IVHDs before enabling IOMMU features Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 3/7] iommu/amd: Introduce an iommu variable for tracking SNP support status Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 4/7] iommu/amd: Introduce function to check and enable SNP Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 5/7] iommu/amd: Set translation valid bit only when IO page tables are in use Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 6/7] iommu/amd: Do not support IOMMU_DOMAIN_IDENTITY after SNP is enabled Suravee Suthikulpanit
2022-06-22 17:11 ` [PATCH v3 7/7] iommu/amd: Do not support IOMMUv2 APIs when " Suravee Suthikulpanit
2022-06-23  8:23   ` Joerg Roedel
2022-06-29 11:54     ` Suthikulpanit, Suravee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220622171131.11870-1-suravee.suthikulpanit@amd.com \
    --to=suravee.suthikulpanit@amd.com \
    --cc=ashish.kalra@amd.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thomas.lendacky@amd.com \
    --cc=vasant.hegde@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®