* [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT
@ 2022-06-26 14:20 Tom Rix
2022-06-27 13:20 ` Aurabindo Pillai
0 siblings, 1 reply; 3+ messages in thread
From: Tom Rix @ 2022-06-26 14:20 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, wenjing.liu,
Jun.Lei, George.Shen, Jimmy.Kizito, Jerry.Zuo, michael.strauss,
aurabindo.pillai
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
sparse reports
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?
drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
Neither of thse variables is used in dc_link_dp.c. Reviewing the commit listed in
the fixes tag shows neither was used in the original patch. So remove them.
Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index be1dcb0a2a06..f3421f2bd52e 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_
return true;
}
-bool FORCE_RATE = false;
-uint32_t FORCE_LANE_COUNT = 0;
-
void decide_link_settings(struct dc_stream_state *stream,
struct dc_link_settings *link_setting)
{
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT
2022-06-26 14:20 [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT Tom Rix
@ 2022-06-27 13:20 ` Aurabindo Pillai
2022-06-27 21:42 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Aurabindo Pillai @ 2022-06-27 13:20 UTC (permalink / raw)
To: Tom Rix, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
wenjing.liu, Jun.Lei, George.Shen, Jimmy.Kizito, Jerry.Zuo,
michael.strauss
Cc: amd-gfx, dri-devel, linux-kernel
On 2022-06-26 10:20, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
>
> Neither of thse variables is used in dc_link_dp.c. Reviewing the commit listed in
> the fixes tag shows neither was used in the original patch. So remove them.
>
> Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index be1dcb0a2a06..f3421f2bd52e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_
> return true;
> }
>
> -bool FORCE_RATE = false;
> -uint32_t FORCE_LANE_COUNT = 0;
> -
> void decide_link_settings(struct dc_stream_state *stream,
> struct dc_link_settings *link_setting)
> {
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT
2022-06-27 13:20 ` Aurabindo Pillai
@ 2022-06-27 21:42 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2022-06-27 21:42 UTC (permalink / raw)
To: Aurabindo Pillai
Cc: Tom Rix, Wentland, Harry, Leo (Sunpeng) Li, Siqueira, Rodrigo,
Deucher, Alexander, Christian Koenig, xinhui pan, Dave Airlie,
Daniel Vetter, Wenjing Liu, Jun Lei, George Shen, Jimmy Kizito,
Jerry Zuo, Michael Strauss, Maling list - DRI developers,
amd-gfx list, LKML
Applied. Thanks!
Alex
On Mon, Jun 27, 2022 at 9:20 AM Aurabindo Pillai
<aurabindo.pillai@amd.com> wrote:
>
>
>
> On 2022-06-26 10:20, Tom Rix wrote:
> > sparse reports
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3885:6: warning: symbol 'FORCE_RATE' was not declared. Should it be static?
> > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:3886:10: warning: symbol 'FORCE_LANE_COUNT' was not declared. Should it be static?
> >
> > Neither of thse variables is used in dc_link_dp.c. Reviewing the commit listed in
> > the fixes tag shows neither was used in the original patch. So remove them.
> >
> > Fixes: 265280b99822 ("drm/amd/display: add CLKMGR changes for DCN32/321")
> > Signed-off-by: Tom Rix <trix@redhat.com>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > index be1dcb0a2a06..f3421f2bd52e 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > @@ -3882,9 +3882,6 @@ static bool decide_mst_link_settings(const struct dc_link *link, struct dc_link_
> > return true;
> > }
> >
> > -bool FORCE_RATE = false;
> > -uint32_t FORCE_LANE_COUNT = 0;
> > -
> > void decide_link_settings(struct dc_stream_state *stream,
> > struct dc_link_settings *link_setting)
> > {
>
>
> Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-27 21:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-26 14:20 [PATCH] drm/amd/display: Remove unused globals FORCE_RATE and FORCE_LANE_COUNT Tom Rix
2022-06-27 13:20 ` Aurabindo Pillai
2022-06-27 21:42 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®