* [PATCH v2] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling
@ 2022-06-27 13:12 Charles Keepax
2022-06-28 0:47 ` Souptick Joarder
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2022-06-27 13:12 UTC (permalink / raw)
To: broonie
Cc: krzysztof.kozlowski, s.nawrocki, jrdr.linux, lgirdwood,
alsa-devel, patches, linux-kernel
The conversion of the set_fmt callback to direct clock specification
included a small typo, correct the affected code.
Fixes: 0b491c7c1b25 ("ASoC: samsung: Update to use set_fmt_new callback")
Reported-by: kernel test robot <lkp@intel.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
Changes since v1:
- Correct fixes tag.
sound/soc/samsung/s3c24xx-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
index 4082ad7cbcc11..c1a314b86b155 100644
--- a/sound/soc/samsung/s3c24xx-i2s.c
+++ b/sound/soc/samsung/s3c24xx-i2s.c
@@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
pr_debug("hw_params r: IISMOD: %x \n", iismod);
switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
- case SND_SOC_DAIFMT_BC_CFC:
+ case SND_SOC_DAIFMT_BC_FC:
iismod |= S3C2410_IISMOD_SLAVE;
break;
case SND_SOC_DAIFMT_BP_FP:
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling
2022-06-27 13:12 [PATCH v2] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling Charles Keepax
@ 2022-06-28 0:47 ` Souptick Joarder
0 siblings, 0 replies; 2+ messages in thread
From: Souptick Joarder @ 2022-06-28 0:47 UTC (permalink / raw)
To: Charles Keepax
Cc: Mark Brown, krzysztof.kozlowski, s.nawrocki, Liam Girdwood,
alsa-devel, patches, linux-kernel
On Mon, Jun 27, 2022 at 6:42 PM Charles Keepax
<ckeepax@opensource.cirrus.com> wrote:
>
> The conversion of the set_fmt callback to direct clock specification
> included a small typo, correct the affected code.
sound/soc/samsung/s3c24xx-i2s.c: In function 's3c24xx_i2s_set_fmt':
>> sound/soc/samsung/s3c24xx-i2s.c:173:14: error: 'SND_SOC_DAIFMT_BC_CFC' undeclared (first use in this function); did you mean 'SND_SOC_DAIFMT_BC_FC'?
173 | case SND_SOC_DAIFMT_BC_CFC:
| ^~~~~~~~~~~~~~~~~~~~~
| SND_SOC_DAIFMT_BC_FC
Adding this actual error msg from the kernel test robot will be helpful.
Reviewed-by: Souptick Joarder (HPE) <jrdr.linux@gmail.com>
>
> Fixes: 0b491c7c1b25 ("ASoC: samsung: Update to use set_fmt_new callback")
> Reported-by: kernel test robot <lkp@intel.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>
> Changes since v1:
> - Correct fixes tag.
>
> sound/soc/samsung/s3c24xx-i2s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/samsung/s3c24xx-i2s.c b/sound/soc/samsung/s3c24xx-i2s.c
> index 4082ad7cbcc11..c1a314b86b155 100644
> --- a/sound/soc/samsung/s3c24xx-i2s.c
> +++ b/sound/soc/samsung/s3c24xx-i2s.c
> @@ -170,7 +170,7 @@ static int s3c24xx_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
> pr_debug("hw_params r: IISMOD: %x \n", iismod);
>
> switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
> - case SND_SOC_DAIFMT_BC_CFC:
> + case SND_SOC_DAIFMT_BC_FC:
> iismod |= S3C2410_IISMOD_SLAVE;
> break;
> case SND_SOC_DAIFMT_BP_FP:
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-28 0:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-27 13:12 [PATCH v2] ASoC: samsung: s3c24xx-i2s: Fix typo in DAIFMT handling Charles Keepax
2022-06-28 0:47 ` Souptick Joarder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®