* [PATCH] drm/vc4: change vc4_dma_range_matches from a global to static
@ 2022-06-29 20:01 Tom Rix
2022-06-30 7:40 ` (subset) " Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2022-06-29 20:01 UTC (permalink / raw)
To: emma, mripard, airlied, daniel, dave.stevenson
Cc: dri-devel, linux-kernel, Tom Rix
sparse reports
drivers/gpu/drm/vc4/vc4_drv.c:270:27: warning: symbol 'vc4_dma_range_matches' was not declared. Should it be static?
vc4_dma_range_matches is only used in vc4_drv.c, so it's storage class specifier
should be static.
Fixes: da8e393e23ef ("drm/vc4: drv: Adopt the dma configuration from the HVS or V3D component")
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 2b014b6332a6..292d1b6a01b6 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -267,7 +267,7 @@ static void vc4_match_add_drivers(struct device *dev,
}
}
-const struct of_device_id vc4_dma_range_matches[] = {
+static const struct of_device_id vc4_dma_range_matches[] = {
{ .compatible = "brcm,bcm2711-hvs" },
{ .compatible = "brcm,bcm2835-hvs" },
{ .compatible = "brcm,bcm2835-v3d" },
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: (subset) [PATCH] drm/vc4: change vc4_dma_range_matches from a global to static
2022-06-29 20:01 [PATCH] drm/vc4: change vc4_dma_range_matches from a global to static Tom Rix
@ 2022-06-30 7:40 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2022-06-30 7:40 UTC (permalink / raw)
To: dave.stevenson, daniel, trix, airlied, emma, mripard
Cc: Maxime Ripard, linux-kernel, dri-devel
On Wed, 29 Jun 2022 16:01:01 -0400, Tom Rix wrote:
> sparse reports
> drivers/gpu/drm/vc4/vc4_drv.c:270:27: warning: symbol 'vc4_dma_range_matches' was not declared. Should it be static?
>
> vc4_dma_range_matches is only used in vc4_drv.c, so it's storage class specifier
> should be static.
>
>
> [...]
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-30 7:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-29 20:01 [PATCH] drm/vc4: change vc4_dma_range_matches from a global to static Tom Rix
2022-06-30 7:40 ` (subset) " Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®