[PATCH] sched/topology: change sched_energy_mutex and sched_energy_update to static

[PATCH] sched/topology: change sched_energy_mutex and sched_energy_update to static

[Tom Rix]

sparse reports
kernel/sched/topology.c:210:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
kernel/sched/topology.c:211:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?

When the commit listed in the fixes tag happened, the sched_energy_mutex
and sched_energy_update variable accesses were wrapped by a function and
the variables were and still are only accessed in the topology.c file.
So change their storage class specifiers to static.

Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
Signed-off-by: Tom Rix <trix@redhat.com>
---
 kernel/sched/topology.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 8739c2a5a54e..412e2ddcade6 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -207,8 +207,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
 #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
 DEFINE_STATIC_KEY_FALSE(sched_energy_present);
 static unsigned int sysctl_sched_energy_aware = 1;
-DEFINE_MUTEX(sched_energy_mutex);
-bool sched_energy_update;
+static DEFINE_MUTEX(sched_energy_mutex);
+static bool sched_energy_update;
 
 void rebuild_sched_domains_energy(void)
 {
-- 
2.27.0

Re: [PATCH] sched/topology: change sched_energy_mutex and sched_energy_update to static

[Valentin Schneider]

On 03/07/22 11:31, Tom Rix wrote:
> sparse reports
> kernel/sched/topology.c:210:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:211:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
>
> When the commit listed in the fixes tag happened, the sched_energy_mutex
> and sched_energy_update variable accesses were wrapped by a function and
> the variables were and still are only accessed in the topology.c file.
> So change their storage class specifiers to static.
>
> Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>