* [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg
@ 2022-07-04 19:04 Colin Ian King
2022-07-05 3:14 ` Jason Wang
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-07-04 19:04 UTC (permalink / raw)
To: Michael S . Tsirkin, Jason Wang, Zhu Lingshan, virtualization
Cc: kernel-janitors, linux-kernel
The assignment to pointer cfg is duplicated, the second assignment
is redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
index 48c4dadb0c7c..47b94091733c 100644
--- a/drivers/vdpa/ifcvf/ifcvf_base.c
+++ b/drivers/vdpa/ifcvf/ifcvf_base.c
@@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
{
struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
- cfg = hw->common_cfg;
vp_iowrite16(vector, &cfg->msix_config);
return vp_ioread16(&cfg->msix_config);
--
2.35.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg
2022-07-04 19:04 [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg Colin Ian King
@ 2022-07-05 3:14 ` Jason Wang
0 siblings, 0 replies; 2+ messages in thread
From: Jason Wang @ 2022-07-05 3:14 UTC (permalink / raw)
To: Colin Ian King
Cc: Michael S . Tsirkin, Zhu Lingshan, virtualization,
kernel-janitors, linux-kernel
On Tue, Jul 5, 2022 at 3:05 AM Colin Ian King <colin.i.king@gmail.com> wrote:
>
> The assignment to pointer cfg is duplicated, the second assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/ifcvf/ifcvf_base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c
> index 48c4dadb0c7c..47b94091733c 100644
> --- a/drivers/vdpa/ifcvf/ifcvf_base.c
> +++ b/drivers/vdpa/ifcvf/ifcvf_base.c
> @@ -29,7 +29,6 @@ u16 ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector)
> {
> struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg;
>
> - cfg = hw->common_cfg;
> vp_iowrite16(vector, &cfg->msix_config);
>
> return vp_ioread16(&cfg->msix_config);
> --
> 2.35.3
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-05 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 19:04 [PATCH] vDPA/ifcvf: remove duplicated assignment to pointer cfg Colin Ian King
2022-07-05 3:14 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®