* [PATCH 1/3] drm/bridge: it6505: Modified power sequence
2022-07-07 8:05 [PATCH 0/3] drm/bridge: it6505: Fixes bugs allen
@ 2022-07-07 8:05 ` allen
2022-07-12 8:07 ` Robert Foss
2022-07-07 8:05 ` [PATCH 2/3] drm/bridge: it6505: Add i2c api power on check allen
2022-07-07 8:05 ` [PATCH 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message allen
2 siblings, 1 reply; 9+ messages in thread
From: allen @ 2022-07-07 8:05 UTC (permalink / raw)
Cc: Allen Chen, Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM DRIVERS, open list
From: allen chen <allen.chen@ite.com.tw>
Change power sequence to meet it6505 data sheet requirement when boot on.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
---
drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 2d119e3016b3..aa5e0aa1af85 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -3029,7 +3029,7 @@ static int it6505_init_pdata(struct it6505 *it6505)
return PTR_ERR(pdata->ovdd);
}
- pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
+ pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
if (IS_ERR(pdata->gpiod_reset)) {
dev_err(dev, "gpiod_reset gpio not found");
return PTR_ERR(pdata->gpiod_reset);
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence
2022-07-07 8:05 ` [PATCH 1/3] drm/bridge: it6505: Modified power sequence allen
@ 2022-07-12 8:07 ` Robert Foss
2022-07-12 9:08 ` Pin-yen Lin
2022-07-12 9:41 ` Chen-Yu Tsai
0 siblings, 2 replies; 9+ messages in thread
From: Robert Foss @ 2022-07-12 8:07 UTC (permalink / raw)
To: allen
Cc: Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
open list:DRM DRIVERS, open list
Hi Allen,
On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@ite.com.tw> wrote:
>
> From: allen chen <allen.chen@ite.com.tw>
>
> Change power sequence to meet it6505 data sheet requirement when boot on.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 2d119e3016b3..aa5e0aa1af85 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -3029,7 +3029,7 @@ static int it6505_init_pdata(struct it6505 *it6505)
> return PTR_ERR(pdata->ovdd);
> }
>
> - pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> + pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
Making this change is problematic since it requires a corresponding
change in all of the device trees that use this device. It's against
policy to change this interface after it has been introduced.
Unless anyone thinks otherwise, I would like to see this patch dropped.
> if (IS_ERR(pdata->gpiod_reset)) {
> dev_err(dev, "gpiod_reset gpio not found");
> return PTR_ERR(pdata->gpiod_reset);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence
2022-07-12 8:07 ` Robert Foss
@ 2022-07-12 9:08 ` Pin-yen Lin
2022-07-12 9:41 ` Chen-Yu Tsai
1 sibling, 0 replies; 9+ messages in thread
From: Pin-yen Lin @ 2022-07-12 9:08 UTC (permalink / raw)
To: Robert Foss
Cc: allen, Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Andrzej Hajda, Neil Armstrong, Laurent Pinchart, Jonas Karlman,
Jernej Skrabec, David Airlie, Daniel Vetter,
open list:DRM DRIVERS, open list
Hi Robert,
On Tue, Jul 12, 2022 at 4:07 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Allen,
>
> On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@ite.com.tw> wrote:
> >
> > From: allen chen <allen.chen@ite.com.tw>
> >
> > Change power sequence to meet it6505 data sheet requirement when boot on.
> >
> > Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> >
> > ---
> > drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> > index 2d119e3016b3..aa5e0aa1af85 100644
> > --- a/drivers/gpu/drm/bridge/ite-it6505.c
> > +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> > @@ -3029,7 +3029,7 @@ static int it6505_init_pdata(struct it6505 *it6505)
> > return PTR_ERR(pdata->ovdd);
> > }
> >
> > - pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> > + pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>
> Making this change is problematic since it requires a corresponding
> change in all of the device trees that use this device. It's against
> policy to change this interface after it has been introduced.
>
> Unless anyone thinks otherwise, I would like to see this patch dropped.
I don't really understand why this would require corresponding change
in device trees.
Currently there's no real it6505 user on upstream. Also, the GPIO
value will be changed
in it6505_poweron, so this change only affects the power on sequence of it6505.
>
> > if (IS_ERR(pdata->gpiod_reset)) {
> > dev_err(dev, "gpiod_reset gpio not found");
> > return PTR_ERR(pdata->gpiod_reset);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/3] drm/bridge: it6505: Modified power sequence
2022-07-12 8:07 ` Robert Foss
2022-07-12 9:08 ` Pin-yen Lin
@ 2022-07-12 9:41 ` Chen-Yu Tsai
1 sibling, 0 replies; 9+ messages in thread
From: Chen-Yu Tsai @ 2022-07-12 9:41 UTC (permalink / raw)
To: Robert Foss
Cc: allen, Kenneth Hung, Jau-Chih Tseng, David Airlie,
open list:DRM DRIVERS, Pin-yen Lin, open list, Jernej Skrabec,
Neil Armstrong, Pin-Yen Lin, Hermes Wu, Laurent Pinchart,
Andrzej Hajda, Jonas Karlman
On Tue, Jul 12, 2022 at 4:08 PM Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Allen,
>
> On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@ite.com.tw> wrote:
> >
> > From: allen chen <allen.chen@ite.com.tw>
> >
> > Change power sequence to meet it6505 data sheet requirement when boot on.
> >
> > Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> > Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
> >
> > ---
> > drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> > index 2d119e3016b3..aa5e0aa1af85 100644
> > --- a/drivers/gpu/drm/bridge/ite-it6505.c
> > +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> > @@ -3029,7 +3029,7 @@ static int it6505_init_pdata(struct it6505 *it6505)
> > return PTR_ERR(pdata->ovdd);
> > }
> >
> > - pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> > + pdata->gpiod_reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>
> Making this change is problematic since it requires a corresponding
> change in all of the device trees that use this device. It's against
> policy to change this interface after it has been introduced.
>
> Unless anyone thinks otherwise, I would like to see this patch dropped.
I think you're confusing GPIO_ACTIVE_{LOW,HIGH} flags in the device tree
vs GPIOD_OUT_{LOW,HIGH}, which just sets the "default" state the GPIO
should be in when it is requested.
This change doesn't impact the device tree.
Regards
ChenYu
> > if (IS_ERR(pdata->gpiod_reset)) {
> > dev_err(dev, "gpiod_reset gpio not found");
> > return PTR_ERR(pdata->gpiod_reset);
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] drm/bridge: it6505: Add i2c api power on check
2022-07-07 8:05 [PATCH 0/3] drm/bridge: it6505: Fixes bugs allen
2022-07-07 8:05 ` [PATCH 1/3] drm/bridge: it6505: Modified power sequence allen
@ 2022-07-07 8:05 ` allen
2022-07-12 8:11 ` Robert Foss
2022-07-07 8:05 ` [PATCH 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message allen
2 siblings, 1 reply; 9+ messages in thread
From: allen @ 2022-07-07 8:05 UTC (permalink / raw)
Cc: Allen Chen, Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM DRIVERS, open list
From: allen chen <allen.chen@ite.com.tw>
Use i2c bus to read/write when it6505 power off will occure i2c error.
Add this check will prevent i2c error when it6505 power off.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
---
drivers/gpu/drm/bridge/ite-it6505.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index aa5e0aa1af85..cfd2c3275dc5 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -518,6 +518,9 @@ static int it6505_read(struct it6505 *it6505, unsigned int reg_addr)
int err;
struct device *dev = &it6505->client->dev;
+ if (!it6505->powered)
+ return -ENODEV;
+
err = regmap_read(it6505->regmap, reg_addr, &value);
if (err < 0) {
dev_err(dev, "read failed reg[0x%x] err: %d", reg_addr, err);
@@ -533,6 +536,9 @@ static int it6505_write(struct it6505 *it6505, unsigned int reg_addr,
int err;
struct device *dev = &it6505->client->dev;
+ if (!it6505->powered)
+ return -ENODEV;
+
err = regmap_write(it6505->regmap, reg_addr, reg_val);
if (err < 0) {
@@ -550,6 +556,9 @@ static int it6505_set_bits(struct it6505 *it6505, unsigned int reg,
int err;
struct device *dev = &it6505->client->dev;
+ if (!it6505->powered)
+ return -ENODEV;
+
err = regmap_update_bits(it6505->regmap, reg, mask, value);
if (err < 0) {
dev_err(dev, "write reg[0x%x] = 0x%x mask = 0x%x failed err %d",
@@ -2553,13 +2562,12 @@ static int it6505_poweron(struct it6505 *it6505)
usleep_range(10000, 20000);
}
+ it6505->powered = true;
it6505_reset_logic(it6505);
it6505_int_mask_enable(it6505);
it6505_init(it6505);
it6505_lane_off(it6505);
- it6505->powered = true;
-
return 0;
}
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] drm/bridge: it6505: Add i2c api power on check
2022-07-07 8:05 ` [PATCH 2/3] drm/bridge: it6505: Add i2c api power on check allen
@ 2022-07-12 8:11 ` Robert Foss
0 siblings, 0 replies; 9+ messages in thread
From: Robert Foss @ 2022-07-12 8:11 UTC (permalink / raw)
To: allen
Cc: Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
open list:DRM DRIVERS, open list
On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@ite.com.tw> wrote:
>
> From: allen chen <allen.chen@ite.com.tw>
>
> Use i2c bus to read/write when it6505 power off will occure i2c error.
^^^ typ-o
Change occure to occur.
This is an issue that would have been caught by running checkpatch
--strict, please try to run it on all patches before submission.
> Add this check will prevent i2c error when it6505 power off.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index aa5e0aa1af85..cfd2c3275dc5 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -518,6 +518,9 @@ static int it6505_read(struct it6505 *it6505, unsigned int reg_addr)
> int err;
> struct device *dev = &it6505->client->dev;
>
> + if (!it6505->powered)
> + return -ENODEV;
> +
> err = regmap_read(it6505->regmap, reg_addr, &value);
> if (err < 0) {
> dev_err(dev, "read failed reg[0x%x] err: %d", reg_addr, err);
> @@ -533,6 +536,9 @@ static int it6505_write(struct it6505 *it6505, unsigned int reg_addr,
> int err;
> struct device *dev = &it6505->client->dev;
>
> + if (!it6505->powered)
> + return -ENODEV;
> +
> err = regmap_write(it6505->regmap, reg_addr, reg_val);
>
> if (err < 0) {
> @@ -550,6 +556,9 @@ static int it6505_set_bits(struct it6505 *it6505, unsigned int reg,
> int err;
> struct device *dev = &it6505->client->dev;
>
> + if (!it6505->powered)
> + return -ENODEV;
> +
> err = regmap_update_bits(it6505->regmap, reg, mask, value);
> if (err < 0) {
> dev_err(dev, "write reg[0x%x] = 0x%x mask = 0x%x failed err %d",
> @@ -2553,13 +2562,12 @@ static int it6505_poweron(struct it6505 *it6505)
> usleep_range(10000, 20000);
> }
>
> + it6505->powered = true;
> it6505_reset_logic(it6505);
> it6505_int_mask_enable(it6505);
> it6505_init(it6505);
> it6505_lane_off(it6505);
>
> - it6505->powered = true;
> -
> return 0;
> }
>
> --
> 2.25.1
>
With that fixed:
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message
2022-07-07 8:05 [PATCH 0/3] drm/bridge: it6505: Fixes bugs allen
2022-07-07 8:05 ` [PATCH 1/3] drm/bridge: it6505: Modified power sequence allen
2022-07-07 8:05 ` [PATCH 2/3] drm/bridge: it6505: Add i2c api power on check allen
@ 2022-07-07 8:05 ` allen
2022-07-12 8:11 ` Robert Foss
2 siblings, 1 reply; 9+ messages in thread
From: allen @ 2022-07-07 8:05 UTC (permalink / raw)
Cc: Allen Chen, Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, open list:DRM DRIVERS, open list
From: allen chen <allen.chen@ite.com.tw>
Speed up video clock calculation and remove redundant video debug message.
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
---
drivers/gpu/drm/bridge/ite-it6505.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index cfd2c3275dc5..11a34ddb60a1 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -703,7 +703,7 @@ static void it6505_calc_video_info(struct it6505 *it6505)
DRM_DEV_DEBUG_DRIVER(dev, "hactive_start:%d, vactive_start:%d",
hdes, vdes);
- for (i = 0; i < 10; i++) {
+ for (i = 0; i < 3; i++) {
it6505_set_bits(it6505, REG_DATA_CTRL0, ENABLE_PCLK_COUNTER,
ENABLE_PCLK_COUNTER);
usleep_range(10000, 15000);
@@ -720,7 +720,7 @@ static void it6505_calc_video_info(struct it6505 *it6505)
return;
}
- sum /= 10;
+ sum /= 3;
pclk = 13500 * 2048 / sum;
it6505->video_info.clock = pclk;
it6505->video_info.hdisplay = hdew;
@@ -2344,8 +2344,6 @@ static void it6505_irq_hpd(struct it6505 *it6505)
if (!it6505_get_video_status(it6505))
it6505_video_reset(it6505);
-
- it6505_calc_video_info(it6505);
} else {
memset(it6505->dpcd, 0, sizeof(it6505->dpcd));
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message
2022-07-07 8:05 ` [PATCH 3/3] drm/bridge: it6505: Modified video clock calculation and video debug message allen
@ 2022-07-12 8:11 ` Robert Foss
0 siblings, 0 replies; 9+ messages in thread
From: Robert Foss @ 2022-07-12 8:11 UTC (permalink / raw)
To: allen
Cc: Pin-yen Lin, Jau-Chih Tseng, Kenneth Hung, Hermes Wu,
Pin-Yen Lin, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
open list:DRM DRIVERS, open list
On Thu, 7 Jul 2022 at 10:06, allen <allen.chen@ite.com.tw> wrote:
>
> From: allen chen <allen.chen@ite.com.tw>
>
> Speed up video clock calculation and remove redundant video debug message.
>
> Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
> Signed-off-by: Allen Chen <allen.chen@ite.com.tw>
>
> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index cfd2c3275dc5..11a34ddb60a1 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -703,7 +703,7 @@ static void it6505_calc_video_info(struct it6505 *it6505)
> DRM_DEV_DEBUG_DRIVER(dev, "hactive_start:%d, vactive_start:%d",
> hdes, vdes);
>
> - for (i = 0; i < 10; i++) {
> + for (i = 0; i < 3; i++) {
> it6505_set_bits(it6505, REG_DATA_CTRL0, ENABLE_PCLK_COUNTER,
> ENABLE_PCLK_COUNTER);
> usleep_range(10000, 15000);
> @@ -720,7 +720,7 @@ static void it6505_calc_video_info(struct it6505 *it6505)
> return;
> }
>
> - sum /= 10;
> + sum /= 3;
> pclk = 13500 * 2048 / sum;
> it6505->video_info.clock = pclk;
> it6505->video_info.hdisplay = hdew;
> @@ -2344,8 +2344,6 @@ static void it6505_irq_hpd(struct it6505 *it6505)
>
> if (!it6505_get_video_status(it6505))
> it6505_video_reset(it6505);
> -
> - it6505_calc_video_info(it6505);
> } else {
> memset(it6505->dpcd, 0, sizeof(it6505->dpcd));
>
> --
> 2.25.1
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 9+ messages in thread