* [PATCH v2 13/14] arch_topology: remove the acpi_disabled check
@ 2022-07-09 14:20 Perry Yuan
2022-07-11 19:28 ` Nathan Fontenot
0 siblings, 1 reply; 2+ messages in thread
From: Perry Yuan @ 2022-07-09 14:20 UTC (permalink / raw)
To: rafael.j.wysocki, viresh.kumar, Ray.Huang
Cc: Deepak.Sharma, Mario.Limonciello, Nathan.Fontenot,
Alexander.Deucher, Jinzhou.Su, Xinmei.Huang, Xiaojian.Du,
Li.Meng, linux-pm, linux-kernel, Perry Yuan
"acpi_cpc_valid" function already includes the acpi_disabled check and we can
remove the duplicated check here
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
drivers/base/arch_topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
index 579c851a2bd7..73a8cb31529d 100644
--- a/drivers/base/arch_topology.c
+++ b/drivers/base/arch_topology.c
@@ -352,7 +352,7 @@ void topology_init_cpu_capacity_cppc(void)
struct cppc_perf_caps perf_caps;
int cpu;
- if (likely(acpi_disabled || !acpi_cpc_valid()))
+ if (likely(!acpi_cpc_valid()))
return;
raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity),
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 13/14] arch_topology: remove the acpi_disabled check
2022-07-09 14:20 [PATCH v2 13/14] arch_topology: remove the acpi_disabled check Perry Yuan
@ 2022-07-11 19:28 ` Nathan Fontenot
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Fontenot @ 2022-07-11 19:28 UTC (permalink / raw)
To: Perry Yuan, rafael.j.wysocki, viresh.kumar, Ray.Huang
Cc: Deepak.Sharma, Mario.Limonciello, Nathan.Fontenot,
Alexander.Deucher, Jinzhou.Su, Xinmei.Huang, Xiaojian.Du,
Li.Meng, linux-pm, linux-kernel
On 7/9/22 09:20, Perry Yuan wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/base/arch_topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c
> index 579c851a2bd7..73a8cb31529d 100644
> --- a/drivers/base/arch_topology.c
> +++ b/drivers/base/arch_topology.c
> @@ -352,7 +352,7 @@ void topology_init_cpu_capacity_cppc(void)
> struct cppc_perf_caps perf_caps;
> int cpu;
>
> - if (likely(acpi_disabled || !acpi_cpc_valid()))
> + if (likely(!acpi_cpc_valid()))
I think this should be included in Patch 11/14 where the acpi_disabled check
is added to acpi_cpc_valid().
-Nathan
> return;
>
> raw_capacity = kcalloc(num_possible_cpus(), sizeof(*raw_capacity),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-11 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 14:20 [PATCH v2 13/14] arch_topology: remove the acpi_disabled check Perry Yuan
2022-07-11 19:28 ` Nathan Fontenot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®