From: Steven Rostedt <rostedt@goodmis.org>
To: Li kunyu <kunyu@nfschina.com>
Cc: mingo@redhat.com, linux-kernel@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] trace: atomic64_read(&ioc->vtime_rate) is assigned an extra semicolon
Date: Mon, 11 Jul 2022 16:55:32 -0400 [thread overview]
Message-ID: <20220711165532.10476a0b@gandalf.local.home> (raw)
In-Reply-To: <20220629030013.10362-1-kunyu@nfschina.com>
Jens,
Want to take this one? Or I can if you don't.
-- Steve
On Wed, 29 Jun 2022 11:00:13 +0800
Li kunyu <kunyu@nfschina.com> wrote:
> I think this semicolon could be deleted.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
> include/trace/events/iocost.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> index e282ce02fa2d..6d1626e7a4ce 100644
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
> @@ -160,7 +160,7 @@ TRACE_EVENT(iocost_ioc_vrate_adj,
>
> TP_fast_assign(
> __assign_str(devname, ioc_name(ioc));
> - __entry->old_vrate = atomic64_read(&ioc->vtime_rate);;
> + __entry->old_vrate = atomic64_read(&ioc->vtime_rate);
> __entry->new_vrate = new_vrate;
> __entry->busy_level = ioc->busy_level;
> __entry->read_missed_ppm = missed_ppm[READ];
next prev parent reply other threads:[~2022-07-11 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 3:00 Li kunyu
2022-07-11 20:55 ` Steven Rostedt [this message]
2022-07-11 20:57 ` Jens Axboe
2022-07-11 21:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220711165532.10476a0b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=axboe@kernel.dk \
--cc=kunyu@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®