* [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
@ 2022-07-14 8:41 Xiu Jianfeng
2022-07-14 8:48 ` Johannes Thumshirn
2022-07-14 10:12 ` Jan Kara
0 siblings, 2 replies; 3+ messages in thread
From: Xiu Jianfeng @ 2022-07-14 8:41 UTC (permalink / raw)
To: akpm, axboe, neilb, johannes.thumshirn, jack, willy, mgorman; +Cc: linux-kernel
inode_to_wb_is_valid() is no longer used since commit fe55d563d417
("remove inode_congested()"), remove it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
---
include/linux/backing-dev.h | 17 -----------------
1 file changed, 17 deletions(-)
diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
index d452071db572..f9f14e385582 100644
--- a/include/linux/backing-dev.h
+++ b/include/linux/backing-dev.h
@@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
return wb;
}
-/**
- * inode_to_wb_is_valid - test whether an inode has a wb associated
- * @inode: inode of interest
- *
- * Returns %true if @inode has a wb associated. May be called without any
- * locking.
- */
-static inline bool inode_to_wb_is_valid(struct inode *inode)
-{
- return inode->i_wb;
-}
-
/**
* inode_to_wb - determine the wb of an inode
* @inode: inode of interest
@@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
return &bdi->wb;
}
-static inline bool inode_to_wb_is_valid(struct inode *inode)
-{
- return true;
-}
-
static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
{
return &inode_to_bdi(inode)->wb;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
2022-07-14 8:41 [PATCH -next] writeback: Cleanup inode_to_wb_is_valid() Xiu Jianfeng
@ 2022-07-14 8:48 ` Johannes Thumshirn
2022-07-14 10:12 ` Jan Kara
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2022-07-14 8:48 UTC (permalink / raw)
To: Xiu Jianfeng, akpm, axboe, neilb, jack, willy, mgorman; +Cc: linux-kernel
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] writeback: Cleanup inode_to_wb_is_valid()
2022-07-14 8:41 [PATCH -next] writeback: Cleanup inode_to_wb_is_valid() Xiu Jianfeng
2022-07-14 8:48 ` Johannes Thumshirn
@ 2022-07-14 10:12 ` Jan Kara
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kara @ 2022-07-14 10:12 UTC (permalink / raw)
To: Xiu Jianfeng
Cc: akpm, axboe, neilb, johannes.thumshirn, jack, willy, mgorman,
linux-kernel
On Thu 14-07-22 16:41:47, Xiu Jianfeng wrote:
> inode_to_wb_is_valid() is no longer used since commit fe55d563d417
> ("remove inode_congested()"), remove it.
>
> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Looks good! Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/backing-dev.h | 17 -----------------
> 1 file changed, 17 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index d452071db572..f9f14e385582 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -235,18 +235,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
> return wb;
> }
>
> -/**
> - * inode_to_wb_is_valid - test whether an inode has a wb associated
> - * @inode: inode of interest
> - *
> - * Returns %true if @inode has a wb associated. May be called without any
> - * locking.
> - */
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> - return inode->i_wb;
> -}
> -
> /**
> * inode_to_wb - determine the wb of an inode
> * @inode: inode of interest
> @@ -345,11 +333,6 @@ wb_get_create_current(struct backing_dev_info *bdi, gfp_t gfp)
> return &bdi->wb;
> }
>
> -static inline bool inode_to_wb_is_valid(struct inode *inode)
> -{
> - return true;
> -}
> -
> static inline struct bdi_writeback *inode_to_wb(struct inode *inode)
> {
> return &inode_to_bdi(inode)->wb;
> --
> 2.17.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-14 10:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 8:41 [PATCH -next] writeback: Cleanup inode_to_wb_is_valid() Xiu Jianfeng
2022-07-14 8:48 ` Johannes Thumshirn
2022-07-14 10:12 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®