* [PATCH] bpf: Fix typo in comments in verifier
@ 2022-07-18 6:52 Kuee K1r0a
2022-07-18 15:35 ` Daniel Müller
0 siblings, 1 reply; 2+ messages in thread
From: Kuee K1r0a @ 2022-07-18 6:52 UTC (permalink / raw)
To: ast
Cc: daniel, john.fastabend, andrii, martin.lau, song, yhs, kpsingh,
sdf, haoluo, jolsa, bpf, linux-kernel, Kuee K1r0a
Replace 'then' with 'than'.
Fixes: f4d7e40a5b71 ("bpf: introduce function calls (verification)")
Signed-off-by: Kuee K1r0a <liulin063@gmail.com>
---
kernel/bpf/verifier.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 0efbac0fd126..4da1a7c7657a 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -1167,7 +1167,7 @@ static int copy_verifier_state(struct bpf_verifier_state *dst_state,
return -ENOMEM;
dst_state->jmp_history_cnt = src->jmp_history_cnt;
- /* if dst has more stack frames then src frame, free them */
+ /* if dst has more stack frames than src frame, free them */
for (i = src->curframe + 1; i <= dst_state->curframe; i++) {
free_func_state(dst_state->frame[i]);
dst_state->frame[i] = NULL;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] bpf: Fix typo in comments in verifier
2022-07-18 6:52 [PATCH] bpf: Fix typo in comments in verifier Kuee K1r0a
@ 2022-07-18 15:35 ` Daniel Müller
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Müller @ 2022-07-18 15:35 UTC (permalink / raw)
To: Kuee K1r0a
Cc: ast, daniel, john.fastabend, andrii, martin.lau, song, yhs,
kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
On Mon, Jul 18, 2022 at 02:52:31PM +0800, Kuee K1r0a wrote:
> Replace 'then' with 'than'.
>
> Fixes: f4d7e40a5b71 ("bpf: introduce function calls (verification)")
> Signed-off-by: Kuee K1r0a <liulin063@gmail.com>
> ---
> kernel/bpf/verifier.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 0efbac0fd126..4da1a7c7657a 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -1167,7 +1167,7 @@ static int copy_verifier_state(struct bpf_verifier_state *dst_state,
> return -ENOMEM;
> dst_state->jmp_history_cnt = src->jmp_history_cnt;
>
> - /* if dst has more stack frames then src frame, free them */
> + /* if dst has more stack frames than src frame, free them */
Should we use plural as well, 'src frames'?
[...]
I believe the patch prefix should indicate which branch the patch targets as
well. E.g., [PATCH bpf-next]. Looks good to me otherwise.
Acked-by: Daniel Müller <deso@posteo.net>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 15:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-18 6:52 [PATCH] bpf: Fix typo in comments in verifier Kuee K1r0a
2022-07-18 15:35 ` Daniel Müller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®