[PATCH] reset: reset-simple should depends on HAS_IOMEM

[PATCH] reset: reset-simple should depends on HAS_IOMEM

[Ben Dooks]

The reset-simple driver does not build on all architecuters as it requires
devm_ioremap_resource() which is only built when CONFIG_HAS_IOMEM is enabled
in the kenrel. Fix the following error by depending on CONFIG_HAS_IOMEM:

drivers/reset/reset-simple.o: in function `reset_simple_probe':
 reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'

Fixes: e87998582b50 ("reset: allow building of reset simple driver if expert config selected")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
---
 drivers/reset/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index f40d9bbb686a..26c81bddf950 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -202,6 +202,7 @@ config RESET_SCMI
 config RESET_SIMPLE
 	bool "Simple Reset Controller Driver" if COMPILE_TEST || EXPERT
 	default ARCH_ASPEED || ARCH_BCM4908 || ARCH_BITMAIN || ARCH_REALTEK || ARCH_STM32 || (ARCH_INTEL_SOCFPGA && ARM64) || ARCH_SUNXI || ARC
+	depends on HAS_IOMEM
 	help
 	  This enables a simple reset controller driver for reset lines that
 	  that can be asserted and deasserted by toggling bits in a contiguous,
-- 
2.35.1

Re: [PATCH] reset: reset-simple should depends on HAS_IOMEM

[Philipp Zabel]

Hi Ben,

On Di, 2022-07-19 at 09:52 +0100, Ben Dooks wrote:
> The reset-simple driver does not build on all architecuters as it requires
> devm_ioremap_resource() which is only built when CONFIG_HAS_IOMEM is enabled
> in the kenrel. Fix the following error by depending on CONFIG_HAS_IOMEM:
> 
> drivers/reset/reset-simple.o: in function `reset_simple_probe':
>  reset-simple.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
> 
> Fixes: e87998582b50 ("reset: allow building of reset simple driver if expert config selected")

Thank you, I changed this to:

Fixes: 18d1909be345 ("reset: allow building of reset simple driver if expert config selected")

and applied to reset/next.

regards
Philipp